Closed
Bug 776349
Opened 12 years ago
Closed 12 years ago
Main toolbox still shown with all toolbars hidden
Categories
(Thunderbird :: Theme, defect)
Thunderbird
Theme
Tracking
(thunderbird15 fixed, thunderbird16 fixed, thunderbird17 fixed)
RESOLVED
FIXED
Thunderbird 17.0
People
(Reporter: Paenglab, Assigned: Paenglab)
References
Details
Attachments
(1 file)
3.73 KB,
patch
|
bwinton
:
review+
bwinton
:
approval-comm-aurora+
bwinton
:
approval-comm-beta+
|
Details | Diff | Splinter Review |
When all toolbars are hidden through menu View > Toolbars the toolbox is still shown with a height of 41px.
Assignee | ||
Comment 1•12 years ago
|
||
This patch removes the toolbox's min-height and adds margins to the toolbar. I can't give a min-height to the toolbar because this let's grow the buttons to full height. So I gave the toolbar top- and bottom-margins to become the height we need for the Australis theme. On Win7 and OSX this is easy with only one button height. On XP and Linux with the big and small icons it's a little bit trickier. I set the :only-of-type to apply only when one toolbar is set. When two toolbars are set they are taller than the minimum height and the margins aren't needed. The only drawback with this is, when two toolbars are defined (with Add toolbar in Customize window) and one is hidden, then the only visible toolbar has no margins. But I think it's really seldom someone uses this configuration.
Comment 2•12 years ago
|
||
Comment on attachment 644756 [details] [diff] [review] patch I like it. r=me! Thanks for the patch!
Attachment #644756 -
Flags: review?(bwinton) → review+
Assignee | ||
Updated•12 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 3•12 years ago
|
||
Comment on attachment 644756 [details] [diff] [review] patch [Approval Request Comment] Bug 763308 is in aurora and beta and I think it makes sense this patch can also land there to solve the issue.
Attachment #644756 -
Flags: approval-comm-beta?
Attachment #644756 -
Flags: approval-comm-aurora?
Comment 4•12 years ago
|
||
Comment on attachment 644756 [details] [diff] [review] patch This fixes a fairly annoying case in Australis, and is just a theme change, so I think pulling it forward is the right move here.
Attachment #644756 -
Flags: approval-comm-beta?
Attachment #644756 -
Flags: approval-comm-beta+
Attachment #644756 -
Flags: approval-comm-aurora?
Attachment #644756 -
Flags: approval-comm-aurora+
Comment 5•12 years ago
|
||
https://hg.mozilla.org/comm-central/rev/f91c69072cf6 https://hg.mozilla.org/releases/comm-aurora/rev/414a1fb495be https://hg.mozilla.org/releases/comm-beta/rev/1a93a4c3cb2a Had to unbitrot c-a and c-b a bit, so please confirm that I didn't mess it up. Thanks.
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
status-thunderbird15:
--- → fixed
status-thunderbird16:
--- → fixed
status-thunderbird17:
--- → fixed
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 17.0
Is this in any way related to bug 748555 (I wait for the current nightly to test it on Win XP)? If not, can you look at it while in the toolbar code? ;)
Assignee | ||
Comment 7•12 years ago
|
||
It isn't related to bug 748555. I'll comment in this bug.
You need to log in
before you can comment on or make changes to this bug.
Description
•