Closed
Bug 776472
Opened 12 years ago
Closed 12 years ago
crash in Accessible::NativeState
Categories
(Core :: Disability Access APIs, defect)
Tracking
()
RESOLVED
FIXED
mozilla17
People
(Reporter: scoobidiver, Assigned: tbsaunde)
References
Details
(Keywords: crash, regression)
Crash Data
Attachments
(1 file)
2.15 KB,
patch
|
davidb
:
review+
|
Details | Diff | Splinter Review |
It first appeared in 17.0a1/20120722. The regression range is: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=446b788ab99d&tochange=462106f027af It's likely a regression from bug 762876. Stack traces are various: Frame Module Signature Source 0 xul.dll nsIFrame::GetStyleXUL layout/style/nsStyleStructList.h:119 1 xul.dll Accessible::NativeState accessible/src/generic/Accessible.cpp:687 2 xul.dll mozilla::a11y::XULMenupopupAccessible::NativeState accessible/src/xul/XULMenuAccessible.cpp:448 3 xul.dll Accessible::State accessible/src/generic/Accessible.cpp:1450 4 xul.dll AccessibleWrap::get_accState accessible/src/msaa/AccessibleWrap.cpp:468 5 rpcrt4.dll Invoke ... Frame Module Signature Source 0 xul.dll nsIFrame::GetStyleXUL layout/style/nsStyleStructList.h:119 1 xul.dll Accessible::NativeState accessible/src/generic/Accessible.cpp:687 2 xul.dll mozilla::a11y::XULButtonAccessible::NativeState accessible/src/xul/XULFormControlAccessible.cpp:96 3 xul.dll Accessible::State accessible/src/generic/Accessible.cpp:1450 4 xul.dll AccessibleWrap::get_accState accessible/src/msaa/AccessibleWrap.cpp:468 5 oleacc.dll AccWrap_Base::get_accState 6 oleacc.dll AccWrap_Annotate::get_accState 7 FSDomNodeFirefox.DLL FSDomNodeFirefox.DLL@0x109d1 ... Frame Module Signature Source 0 libxul.so Accessible::NativeState nsStyleStructList.h:119 1 libxul.so HyperTextAccessible::NativeState accessible/src/generic/HyperTextAccessible.cpp:124 2 libxul.so mozilla::a11y::XULLabelAccessible::NativeState accessible/src/xul/XULElementAccessibles.cpp:55 3 libxul.so Accessible::State accessible/src/generic/Accessible.cpp:1450 4 libxul.so refStateSetCB accessible/src/atk/AccessibleWrap.cpp:885 5 libatk-1.0.so.0.20409.1 libatk-1.0.so.0.20409.1@0xb255 ... More reports at: https://crash-stats.mozilla.com/report/list?signature=nsIFrame%3A%3AGetStyleXUL%28%29 https://crash-stats.mozilla.com/report/list?signature=Accessible%3A%3ANativeState
Comment 1•12 years ago
|
||
Assigning based on suspected regression cause.
Assignee: nobody → trev.saunders
Assignee | ||
Comment 2•12 years ago
|
||
Attachment #644982 -
Flags: review?(dbolter)
Comment 3•12 years ago
|
||
Comment on attachment 644982 [details] [diff] [review] patch Review of attachment 644982 [details] [diff] [review]: ----------------------------------------------------------------- Why not just check the frame before using it (a one line patch)?
Assignee | ||
Comment 4•12 years ago
|
||
(In reply to David Bolter [:davidb] from comment #3) > Comment on attachment 644982 [details] [diff] [review] > patch > > Review of attachment 644982 [details] [diff] [review]: > ----------------------------------------------------------------- > > Why not just check the frame before using it (a one line patch)? trying to not check things multiple times, something wrong with it?
Comment 5•12 years ago
|
||
(In reply to Trevor Saunders (:tbsaunde) from comment #4) > (In reply to David Bolter [:davidb] from comment #3) > trying to not check things multiple times, something wrong with it? I guess it is either two isXUL checks or two frame checks, I'm more used to frame checks but meh.
Updated•12 years ago
|
Attachment #644982 -
Flags: review?(dbolter) → review+
Comment 6•12 years ago
|
||
I hit this crash while trying to test another bug - https://crash-stats.mozilla.com/report/index/bp-c3b3de8d-3952-4aab-8fb6-089d12120723. At the time of the crash I was using the back button to navigate back from a site. If I can reproduce I will let you know.
Assignee | ||
Comment 7•12 years ago
|
||
landed https://hg.mozilla.org/integration/mozilla-inbound/rev/fcc58ba01ef6
Assignee | ||
Comment 8•12 years ago
|
||
(In reply to David Bolter [:davidb] from comment #5) > (In reply to Trevor Saunders (:tbsaunde) from comment #4) > > (In reply to David Bolter [:davidb] from comment #3) > > > trying to not check things multiple times, something wrong with it? > > I guess it is either two isXUL checks or two frame checks, I'm more used to > frame checks but meh. true, but I realized I'd have to do the second IsXUL() check after I started changing stuff...
Comment 9•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/fcc58ba01ef6
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in
before you can comment on or make changes to this bug.
Description
•