Closed
Bug 776511
Opened 12 years ago
Closed 12 years ago
Remove the observers added by chat-messenger-overlay.js when closing a messenger window
Categories
(Thunderbird :: Instant Messaging, defect)
Thunderbird
Instant Messaging
Tracking
(thunderbird15 fixed, thunderbird16 fixed)
RESOLVED
FIXED
Thunderbird 17.0
People
(Reporter: florian, Assigned: florian)
Details
Attachments
(1 file)
4.75 KB,
patch
|
mconley
:
review+
bwinton
:
approval-comm-aurora+
bwinton
:
approval-comm-beta+
|
Details | Diff | Splinter Review |
For some reason, when I initially wrote that code I assumed that now that Thunderbird has tabs, there's only one messenger window with the same life time as the application, so removing the observers wasn't needed. This is obviously wrong, so here's a patch to fix this. Note: the patch from bug 775105 needs to be applied before this patch.
Attachment #644914 -
Flags: review?(mconley)
Comment 1•12 years ago
|
||
Comment on attachment 644914 [details] [diff] [review] Patch I'm fine with this - thanks Florian.
Attachment #644914 -
Flags: review?(mconley) → review+
Assignee | ||
Updated•12 years ago
|
Attachment #644914 -
Flags: approval-comm-beta?
Attachment #644914 -
Flags: approval-comm-aurora?
Comment 2•12 years ago
|
||
Comment on attachment 644914 [details] [diff] [review] Patch This seems like something we want for the initial IM release.
Attachment #644914 -
Flags: approval-comm-beta?
Attachment #644914 -
Flags: approval-comm-beta+
Attachment #644914 -
Flags: approval-comm-aurora?
Attachment #644914 -
Flags: approval-comm-aurora+
Comment 3•12 years ago
|
||
comm-central: https://hg.mozilla.org/comm-central/rev/378040aa810f comm-aurora: https://hg.mozilla.org/releases/comm-aurora/rev/3a5ec8e368d2 comm-beta: https://hg.mozilla.org/releases/comm-beta/rev/e3a652e552f2
Status: NEW → RESOLVED
Closed: 12 years ago
status-thunderbird15:
--- → fixed
status-thunderbird16:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 17.0
You need to log in
before you can comment on or make changes to this bug.
Description
•