Closed Bug 776539 Opened 12 years ago Closed 12 years ago

Move FormData to Paris bindings

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla20

People

(Reporter: Ms2ger, Assigned: Ms2ger)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached patch WIP (obsolete) — Splinter Review
This doesn't build, because of workers.
What's the build failure, exactly?
Assignee: nobody → Ms2ger
Blocks: 819328
Attached patch Patch v1Splinter Review
Attachment #644929 - Attachment is obsolete: true
Attachment #689701 - Flags: review?(bzbarsky)
Comment on attachment 689701 [details] [diff] [review]
Patch v1

>+  "FormData interface constructor": true

Is there a bug covering this?

>+  // void append(DOMString name, Blob value, optional DOMString filename);

You might as well uncomment that and just have the implementation ignore the last arg, which is what would happen anyway right now, just in binding code.  Would make it simpler to later update things to have it work.

r=me with that.
Attachment #689701 - Flags: review?(bzbarsky) → review+
(In reply to Boris Zbarsky (:bz) from comment #3)
> Comment on attachment 689701 [details] [diff] [review]
> Patch v1
> 
> >+  "FormData interface constructor": true
> 
> Is there a bug covering this?

Bug 793151, which I guess I should land.
Yes, please!
We should land this sooner rather than later, because until we do xhr send() is kinda broken if passed in a random object...
https://hg.mozilla.org/mozilla-central/rev/2fb469965c13
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: