776542 - firefox 10.0.6 fail to compile with "undefined reference to `js_IntToString(JSContext*, int)'"

Status: RESOLVED INVALID

(Core :: JavaScript Engine, defect)

Description

[Jory A. Pratt [:anarchy]]

/usr/bin/python2.7 /var/tmp/portage/mail-client/thunderbird-10.0.6/work/comm-esr10/mozilla/js/src/config/pythonpath.py -I../config /var/tmp/portage/mail-client/thunderbird-10.0.6/work/comm-esr10/mozilla/js/src/config/expandlibs_exec.py --uselist --  i686-pc-linux-gnu-g++ -o js  -fno-rtti -Wall -Wpointer-arith -Woverloaded-virtual -Wsynth -Wno-ctor-dtor-privacy -Wno-non-virtual-dtor -Wcast-align -Wno-invalid-offsetof -Wno-variadic-macros -Werror=return-type -march=native -pipe -Wno-return-type -w -mno-avx -fno-tree-vrp -pthread -pipe  -DNDEBUG -DTRIMMED -g -O2 -fomit-frame-pointer js.o jsworkers.o jsoptparse.o jsheaptools.o   -lpthread -Wl,-O1 -Wl,--as-needed -Wl,--hash-style=gnu   -Wl,-rpath-link,../../../dist/bin -Wl,-rpath-link,/var/tmp/portage/mail-client/thunderbird-10.0.6/work/comm-esr10/tbird/mozilla/dist/lib   -Wl,--whole-archive ../../../dist/lib/libmozutils.a -Wl,--no-whole-archive -rdynamic -L../../../dist/bin -L../../../dist/lib -Wl,-R/usr/lib -L/usr/lib -lplds4 -lplc4 -lnspr4 -lpthread -ldl ../editline/libeditline.a ../libjs_static.a -ldl  -lffi    
../libjs_static.a(jstracer.o):(.data.rel+0x0): undefined reference to `js_IntToString(JSContext*, int)'

Comment 1

[Luke Wagner [:luke]]

jstracer.o...

Comment 2

[Jory A. Pratt [:anarchy]]

(In reply to Luke Wagner [:luke] from comment #1)
> jstracer.o...

Yes the object is the result of jstracer.cpp which is only place we see js_IntToString that was removed in your patch for memory corruption of strings.

Comment 3

[Luke Wagner [:luke]]

Wow, I didn't realize jstracer.cpp was still present in esr10.  How did this not bust immediately on landing?  Does FF branch build with --disable-tracejit?

Comment 4

[Jory A. Pratt [:anarchy]]

(In reply to Luke Wagner [:luke] from comment #3)
> Wow, I didn't realize jstracer.cpp was still present in esr10.  How did this
> not bust immediately on landing?  Does FF branch build with
> --disable-tracejit?

I am in the middle of building with --disable-tracejit, in theory it will work due to the defines in Makefile.in. I could not answer how we did not see the breakage when landing initially.

Comment 5

[Luke Wagner [:luke]]

It seem to me that esr10 builds with --disable-tracejit.  That is entirely reasonable.

Comment 6

[Jory A. Pratt [:anarchy]]

We are way past this now.