776556 - Code Signing breaks ASan OSX builds

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Christian Holler (:decoder)]

Attachment: Disable package signing when --disable-install-strip is used

Since recently I'm hitting the following error with the ASan OSX try builds:

2012-07-23 03:38:15,611 - 9a0a3e00bc5221d486ea26cca848ec9f0c9279db: processing FirefoxNightlyDebug.app.tar.gz on https://mac-signing3.build.scl1.mozilla.com:9100
2012-07-23 03:38:15,811 - 9a0a3e00bc5221d486ea26cca848ec9f0c9279db: uploading for signing
2012-07-23 03:38:22,888 - 9a0a3e00bc5221d486ea26cca848ec9f0c9279db: error uploading file for signing: File too large


I guess this is due to ASan builds not being stripped, so I would suggest to disable signing builds that are built with --disable-install-strip. Patch is attached and seems to work but I'd prefer confirmation that this is a reasonable way to go and that the patch is actually doing the right thing :)

Comment 1

[(not currently active) Ted Mielczarek]

This can't quite be right, because our normal Mac nightlies also specify --disable-install-strip:
https://hg.mozilla.org/mozilla-central/file/9792ee3e5244/browser/config/mozconfigs/macosx-universal/nightly#l9

How big are ASan builds compared to normal Mac nightly builds?

Comment 2

[Christian Holler (:decoder)]

Attachment: Disable package signing when ASan is enabled

Catlee suggested to just disable the signing when building with ASan, so I altered the patch to do exactly that.

Comment 3

[(not currently active) Ted Mielczarek]

Comment on attachment 646132 [details] [diff] [review]
Disable package signing when ASan is enabled

Review of attachment 646132 [details] [diff] [review]:
-----------------------------------------------------------------

Kind of hacky, but okay. Might be nice to have a --disable-codesigning configure option or something like that.

Comment 4

[Christian Holler (:decoder)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/81478acd423f

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/81478acd423f