776633 - [Checkins] Firebot should publish https links to hg.mozilla.org

Status: RESOLVED WORKSFORME

(Webtools Graveyard :: Mozbot, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

When check-ins are made to any of the hg.mozilla.org trees, firebot posts the check-in info to #developers. e.g:

firebot: Check-in: http://hg.mozilla.org/integration/mozilla-inbound/rev/727381afb1be - Kartikaya Gupta - Bug 774205 - Guard against a null layer controller object in GeckoInputConnection. r=cpeterson

The link contained in this message is an "http" link. It would be better to use "https" links, as that seems to be the standard Mozilla practice.

Comment 1

[Wolf [:wolf]]

For actually /doing/ something, i'm sure. but since hg doesn't redirect, but serves the pages over http, i'm not sure how much it matters.

Its a one line change. Low-priority though. (Something to think about when rewriting this module, in fact.)

Comment 2

[Kartikaya Gupta (email:[e-mail])]

(In reply to Wolf [:wolf] from comment #1)
> For actually /doing/ something, i'm sure. but since hg doesn't redirect, but
> serves the pages over http, i'm not sure how much it matters.

I'm not sure what you mean here. FWIW the reason I care is that I would like to just copy the URL from firebot to the bug after I land a patch on inbound. If it were an https URL I wouldn't need to modify it manually. Yes, I'm that lazy :)

Comment 3

[Wolf [:wolf]]

(In reply to Kartikaya Gupta (:kats) from comment #2)
> I'm not sure what you mean here. FWIW the reason I care is that I would like
> to just copy the URL from firebot to the bug after I land a patch on
> inbound. If it were an https URL I wouldn't need to modify it manually. Yes,
> I'm that lazy :)

Just saying that i'm not sure there's a strong push for https for hg for viewing these pages. I didn't understand what you meant by standard practice before (and didn't realize I didn't either.), but this clarifies that. I understand your desire here and will fix it. :-) I'm all for lazy.

Comment 4

[Wolf [:wolf]]

Hmm.. I thought this module generated the URLs itself, but it actually gets it from the RSS feed on the Hg side, now that I look at the code. That makes it harder to fix.

Comment 5

[Wolf [:wolf]]

Is this still an issue? Or has the Hg configuration changed to its RSS feeds return https URLs?

Comment 6

[Kartikaya Gupta (email:[e-mail])]

Well, firebot is still reporting http URLs in #developers. And the feed at e.g. https://hg.mozilla.org/integration/mozilla-inbound/atom-log has http URLs. If this is better implemented as an hg configuration change please feel free to move the bug.

Comment 7

[Kartikaya Gupta (email:[e-mail])]

I think pulsebot does https now.