Closed
Bug 776726
Opened 12 years ago
Closed 12 years ago
osx panel shows up black for a moment
Categories
(Firefox Graveyard :: SocialAPI, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 17
People
(Reporter: mixedpuppy, Assigned: mixedpuppy)
Details
(Whiteboard: [Fx16])
Attachments
(1 file)
685 bytes,
patch
|
jaws
:
review+
|
Details | Diff | Splinter Review |
social panels are styled white, but the default styling takes over for just a moment while opening the status panels.
Assignee | ||
Comment 1•12 years ago
|
||
Attachment #645097 -
Flags: review?(jaws)
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → mixedpuppy
Comment 2•12 years ago
|
||
I don't think this is the right way to go about fixing it. Is there a way to prevent the flash of blank background?
Comment 3•12 years ago
|
||
Comment on attachment 645097 [details] [diff] [review] style patch Review of attachment 645097 [details] [diff] [review]: ----------------------------------------------------------------- What would -moz-appearance:none; do here?
Attachment #645097 -
Flags: review?(jaws) → review-
Comment 4•12 years ago
|
||
Comment on attachment 645097 [details] [diff] [review] style patch Review of attachment 645097 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/themes/pinstripe/browser.css @@ +3455,5 @@ > max-height: 600px; > max-width: 400px; > } > > #social-notification-panel .panel-arrowcontent { Can you change this and the other selectors for #social-notification-panel to use child selectors as part of this patch? @@ +3459,5 @@ > #social-notification-panel .panel-arrowcontent { > margin: -4px 0 0 0; > padding: 0; > border-radius: 0px; > + background: white; I talked this over with Gavin and Shane, and this will be fine for Fx16.
Attachment #645097 -
Flags: review- → review+
Comment 5•12 years ago
|
||
Changed from "background" to "background-color" on checkin: https://hg.mozilla.org/mozilla-central/rev/f263db41eaa9
Status: NEW → RESOLVED
Closed: 12 years ago
Hardware: x86 → All
Resolution: --- → FIXED
Target Milestone: --- → Firefox 17
Comment 6•12 years ago
|
||
(In reply to :Gavin Sharp (use gavin@gavinsharp.com for email) from comment #5) > Changed from "background" to "background-color" on checkin: Which broke things! Fixed: https://hg.mozilla.org/integration/mozilla-inbound/rev/0d0e381119c9
Comment 7•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/0d0e381119c9
Updated•5 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•