776764 - Allow permissionDB parent directory to not be the default profile directory

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Comment 1

[Gregor Wagner [:gwagner]]

Attachment: patch

Comment 2

[Gregor Wagner [:gwagner]]

Attachment: patch

Comment 3

[Gregor Wagner [:gwagner]]

Attachment: patch

Also update the directoryProvider

Comment 4

[[:fabrice] Fabrice Desré]

Comment on attachment 645159 [details] [diff] [review]
patch

Review of attachment 645159 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with the nits addressed.

::: b2g/components/DirectoryProvider.js
@@ +21,5 @@
>    QueryInterface: XPCOMUtils.generateQI([Ci.nsIDirectoryServiceProvider]),
>  
>    getFile: function dp_getFile(prop, persistent) {
>  #ifdef MOZ_WIDGET_GONK
> +    let localProps = ["cachePDir", "webappsDir", "PrefD", "indexedDBPDir", "permisionDBDir"];

Ditto: 'permissionDBPDir

::: extensions/cookie/nsPermissionManager.cpp
@@ +306,5 @@
> +  nsresult rv = NS_GetSpecialDirectory(NS_APP_PERMISSION_PARENT_DIR, getter_AddRefs(permissionsFile));
> +  if (NS_FAILED(rv)) {
> +    rv = NS_GetSpecialDirectory(NS_APP_USER_PROFILE_50_DIR, getter_AddRefs(permissionsFile));
> +  }
> +  NS_ENSURE_SUCCESS(rv, nsnull);

why nsnull and not NS_ENSURE_SUCCESS(rv, NS_ERROR_UNEXPECTED) ?

::: xpcom/io/nsAppDirectoryServiceDefs.h
@@ +88,5 @@
>  #define NS_APP_STORAGE_50_FILE                  "UStor" // sqlite database used as mozStorage profile db
>  
>  #define NS_APP_INDEXEDDB_PARENT_DIR             "indexedDBPDir"
> +
> +#define NS_APP_PERMISSION_PARENT_DIR            "permisionDBDir"

I would use permissionDBPDir ('P' for parent, and also you have a typo with a missing 's')

Comment 5

[Gregor Wagner [:gwagner]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d9419716db6f

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/d9419716db6f