776822 - Many Makefile's from dom/ missing from toolkit-makefiles.sh

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Gregory Szorc [:gps]]

There are a number of Makefile's in dom/ missing from allmakefiles.sh.

Non-comprehensive list:

dom/interfaces/settings/Makefile
dom/apps/Makefile
dom/bindings/Makefile
dom/browser-element/Makefile
dom/devicestorage/Makefile
dom/contacts/Makefile
dom/media/Makefile
dom/settings/Makefile
dom/mms/Makefile
dom/identity/Makefile
dom/imptests/Makefile
dom/bindings/test/Makefile

Comment 1

[Gregory Szorc [:gps]]

Errr - I guess there is some magic going on inside dom/. Possibly inherited from dom-config.mk? I have a feeling I shouldn't go down this rabbit hole...

Comment 2

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

allmakefiles.sh is a performance optimization.  Not being listed doesn't break anything, *unless* the directory omitted is a top-level directory (it's built from tier_*_dirs and not from DIRS or PARALLEL_DIRS).

Comment 3

[Gregory Szorc [:gps]]

Attachment: Add missing Makefile's in dom/, v1

This avoid make-makefile in dom/ in my local build.

Try at http://tbpl.mozilla.org/?tree=Try&rev=5a42ea6ea663. Maybe. Try seems to be having issues.

Comment 4

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 646474 [details] [diff] [review]
Add missing Makefile's in dom/, v1

Review of attachment 646474 [details] [diff] [review]:
-----------------------------------------------------------------

I didn't actually look at this.  I assume you know what you're doing.

Comment 5

[Gregory Szorc [:gps]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/375d278adbd1

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/375d278adbd1