776862 - "Restore Default Set" on the chat toolbar selects "Icons" even though "Icons beside Text" is the visible result

Status: RESOLVED FIXED

(Thunderbird :: Instant Messaging, defect)

Description

[Florian Quèze [:florian]]

STR:
- Open the chat tab (click the "Chat" button of the mail toolbar).
- Right click on the chat toolbar and select "Customize"
- Click the "Restore Default Set" button.

Expected result:
"Show: Icons beside Text"

Actual result
"Show: Icons"

Comment 1

[Florian Quèze [:florian]]

Attachment: Patch

This patch fixes the bug, but I don't know this toolbar code at all, I just copied what's done on mail-toolbox at http://mxr.mozilla.org/comm-central/source/mail/base/content/mailWindowOverlay.xul#1737 which hopefully make sense.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 645238 [details] [diff] [review]
Patch

Review of attachment 645238 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good - thanks.

Comment 3

[Florian Quèze [:florian]]

[Approval Request Comment]
This is really a tiny detail, but the patch is really not risky either, so requesting approval for Tb15 anyway.

Comment 4

[Mike Conley (:mconley) (:⚙️)]

comm-central: https://hg.mozilla.org/comm-central/rev/26af51de257c
comm-aurora: https://hg.mozilla.org/releases/comm-aurora/rev/f7a52a7a0008
comm-beta: https://hg.mozilla.org/releases/comm-beta/rev/9e928d9d2ba5