776876 - GLContextProviderEGL nullptr related build error with vc11

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Jim Mathies [:jimm]]

GLContextProviderEGL.cpp
f:/Mozilla/firefox/elm/gfx/gl/GLContextProviderEGL.cpp(891) : error C2440: 'return' : cannot convert from 'nullptr' to 'mozilla::gl::SharedTextureHandle'
        A native nullptr can only be converted to bool or, using reinterpret_cast, to an integral type
f:/Mozilla/firefox/elm/gfx/gl/GLContextProviderEGL.cpp(894) : error C2440: 'return' : cannot convert from 'nullptr' to 'mozilla::gl::SharedTextureHandle'
        A native nullptr can only be converted to bool or, using reinterpret_cast, to an integral type
f:/Mozilla/firefox/elm/gfx/gl/GLContextProviderEGL.cpp(906) : error C2440: 'return' : cannot convert from 'nullptr' to 'mozilla::gl::SharedTextureHandle'
        A native nullptr can only be converted to bool or, using reinterpret_cast, to an integral type
f:/Mozilla/firefox/elm/gfx/gl/GLContextProviderEGL.cpp(920) : error C2440: 'return' : cannot convert from 'nullptr' to 'mozilla::gl::SharedTextureHandle'
        A native nullptr can only be converted to bool or, using reinterpret_cast, to an integral type
f:/Mozilla/firefox/elm/gfx/gl/GLContextProviderEGL.cpp(934) : error C2440: 'return' : cannot convert from 'nullptr' to 'mozilla::gl::SharedTextureHandle'
        A native nullptr can only be converted to bool or, using reinterpret_cast, to an integral type
f:/Mozilla/firefox/elm/gfx/gl/GLContextProviderEGL.cpp(941) : error C2440: 'return' : cannot convert from 'nullptr' to 'mozilla::gl::SharedTextureHandle'
        A native nullptr can only be converted to bool or, using reinterpret_cast, to an integral type
f:/Mozilla/firefox/elm/gfx/gl/GLContextProviderEGL.cpp(948) : error C2440: 'return' : cannot convert from 'nullptr' to 'mozilla::gl::SharedTextureHandle'
        A native nullptr can only be converted to bool or, using reinterpret_cast, to an integral type
make[4]: *** [GLContextProviderEGL.obj] Error 2

Comment 1

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

It looks like SharedTextureHandle is a typedef for uintptr_t.  The simple workaround would be to change "nsnull" in all these places to "0".  Alternatively, SharedTextureHandle could be redefined -- I'm puzzled as to why it should be uintptr_t instead of void* or such.  (Actually, I'm not clear what uintptr_t is actually useful for at all!)

Comment 2

[Jim Mathies [:jimm]]

Attachment: patch

Comment 3

[Joe Drew (not getting mail)]

Comment on attachment 645271 [details] [diff] [review]
patch

Change the typedef instead - I'm allergic to 0s!

Comment 4

[Jim Mathies [:jimm]]

There are two ways to do this. Changing SharedTextureHandle to void* works, but for me it is less clear than uintptr_t. If we keep uintptr_t, we can change the return values to reinterpret_cast<uintptr_t>(nsnull), which will ultimately get mass changed to reinterpret_cast<uintptr_t>(nullptr).

I'm fine with either, but I like the second solution better.

Joe, preference?

Comment 5

[Joe Drew (not getting mail)]

Much prefer the first, because it lets us just return nsnull. But listen to your heart on this. :)

Comment 6

[Jim Mathies [:jimm]]

Attachment: patch

void* it is!

Comment 7

[Joe Drew (not getting mail)]

Comment on attachment 645410 [details] [diff] [review]
patch

hooray

Comment 8

[Jim Mathies [:jimm]]

This blew up on inbound in ipc code - 

error: no member named 'Write' in 'IPC::ParamTraits<void *>'

https://tbpl.mozilla.org/php/getParsedLog.php?id=13813311&tree=Mozilla-Inbound&full=1

So me thinks we need to go with option two.

Comment 9

[Joe Drew (not getting mail)]

sadface

Comment 11

[Oleg Romashin (:romaxa)]

Attachment: Proper fix for nullptr build error

Comment 12

[Jim Mathies [:jimm]]

(In reply to Oleg Romashin (:romaxa) from comment #11)
> Created attachment 645879 [details] [diff] [review]
> Proper fix for nullptr build error

This patch is already on inbound, it landed this morning.

https://hg.mozilla.org/integration/mozilla-inbound/rev/b00c1e7289da

Comment 13

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/b00c1e7289da