Closed Bug 777094 Opened 12 years ago Closed 12 years ago

Qt fail to compile due to wrong GL includes order

Categories

(Core Graveyard :: Widget: Qt, defect)

Product:
Core Graveyard
Component:
Widget: Qt
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla17

People

(Reporter: romaxa, Assigned: romaxa)

References

Details

(Keywords: regression)

Attachments

(1 file, 1 obsolete file)

Put QGL include before GLDefs.h
1.49 KB, patch
dougt
: review+
Details | Diff | Splinter Review 
Qt build got busted in inbound after some recent fix which bring GLDefs.h include into nsWindow.h:
https://tbpl.mozilla.org/php/getParsedLog.php?id=13786738&tree=Mozilla-Inbound#error0
That broke qgl.h include because __gl_h_ got defined disabled include for GL/gl.h and GLDefs don't have standard non-local GL defines 

probably bug 776217, not sure
Tested on maemo and desktop qt build
Assignee: nobody → romaxa
Attachment #645523 - Flags: review?(doug.turner)
Comment on attachment 645523 [details] [diff] [review]
Put QGL include before GLDefs.h

rs+
Attachment #645523 - Flags: review?(doug.turner) → review+
GLDefs version
Attachment #645532 - Flags: review?(jones.chris.g)
Comment on attachment 645532 [details] [diff] [review]
GLIfdef fix, to avoid breakage in future

oh, this will not work. and break ipdl compilation
Attachment #645532 - Attachment is obsolete: true
Attachment #645532 - Flags: review?(jones.chris.g)
The breakage started with bug 771350
Blocks: 771350
Keywords: checkin-needed
Keywords: regression
Please remove the checkin-needed when you land your patches.
Flags: in-testsuite-
Keywords: checkin-needed
oh, sorry forgot about that while was fighting with closed tree behaviour
https://hg.mozilla.org/mozilla-central/rev/ef6fac0c8330
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: