Closed Bug 777243 Opened 12 years ago Closed 12 years ago

Intermittent Android test_bug760802.html | an unexpected uncaught JS exception reported through window.onerror - TypeError: win.gBrowser is undefined at widget/tests/test_bug760802.html:53

Categories

(Core :: Widget, defect)

Product:
Core
Component:
Widget
Platform:
ARM
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla17

People

(Reporter: cjones, Assigned: foudil.newbie+bmo)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file, 1 obsolete file)

with simpler docShell get
1.67 KB, patch
roc
: review+
Details | Diff | Splinter Review 
Seen on 

https://tbpl.mozilla.org/php/getParsedLog.php?id=13826335&tree=Mozilla-Inbound

Android Tegra 250 mozilla-inbound opt test mochitest-8 on 2012-07-24 21:22:19 PDT for push b0fdbf25855a

slave: tegra-120

71714 ERROR TEST-UNEXPECTED-FAIL | /tests/widget/tests/test_bug760802.html | an unexpected uncaught JS exception reported through window.onerror - TypeError: win.gBrowser is undefined at http://mochi.test:8888/tests/widget/tests/test_bug760802.html:53
I/GeckoDump( 1644): 71714 ERROR TEST-UNEXPECTED-FAIL | /tests/widget/tests/test_bug760802.html | an unexpected uncaught JS exception reported through window.onerror - TypeError: win.gBrowser is undefined at http://mochi.test:8888/tests/widget/tests/test_bug760802.html:53

Guessing it's a new intermittent failure.  Not sure if bug 760802 is at fault, but setting to block to get some eyes on this.
Looking not-so-intermittent ...

https://tbpl.mozilla.org/php/getParsedLog.php?id=13828675&tree=Mozilla-Inbound
Summary: ERROR TEST-UNEXPECTED-FAIL | /tests/widget/tests/test_bug760802.html | an unexpected uncaught JS exception reported through window.onerror - TypeError: win.gBrowser is undefined at http://mochi.test:8888/tests/widget/tests/test_bug760802.html:53 → Failure in test_bug760802.html | an unexpected uncaught JS exception reported through window.onerror - TypeError: win.gBrowser is undefined at widget/tests/test_bug760802.html:53
This test last ran to completion without infra failures on

emorley@mozilla.com – Tue Jul 24 06:39:51 2012 PDT 
d4982fbe4fa8

where it was green.
https://tbpl.mozilla.org/php/getParsedLog.php?id=13830867&tree=Mozilla-Inbound
Blocks: 438871
OS: Linux → Android
Hardware: x86_64 → ARM
Whiteboard: [orange]
Summary: Failure in test_bug760802.html | an unexpected uncaught JS exception reported through window.onerror - TypeError: win.gBrowser is undefined at widget/tests/test_bug760802.html:53 → Intermittent Android test_bug760802.html | an unexpected uncaught JS exception reported through window.onerror - TypeError: win.gBrowser is undefined at widget/tests/test_bug760802.html:53
Attached patch no gBrowser in Android (obsolete) — — Splinter Review 
My bad, I wrongly followed examples intended MOZ_WIDGET_TOOLKIT=windows. gBrowser is not defined for Android. Here's a fix.
https://tbpl.mozilla.org/?tree=Try&rev=028322613e14 looks OK to me.
Attachment #646115 - Flags: review?(roc)
Comment on attachment 646115 [details] [diff] [review]
no gBrowser in Android

Review of attachment 646115 [details] [diff] [review]:
-----------------------------------------------------------------

r+ anyway

::: widget/tests/test_bug760802.html
@@ +39,5 @@
> +    .QueryInterface(Ci.nsIDocShellTreeItem)
> +    .treeOwner
> +    .QueryInterface(Ci.nsIInterfaceRequestor)
> +    .getInterface(Ci.nsIXULWindow)
> +    .docShell

Is this docShell step needed? Seems to me it should not be.
Attachment #646115 - Flags: review?(roc) → review+
Keywords: checkin-needed
Assignee: nobody → foudil.newbie+bugzilla.mozilla.org

        Attachment #646115 -
        Attachment is obsolete: true
Status: NEW → ASSIGNED

        Attachment #646404 -
        Flags: review?(roc)

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/a7e20d9dc2f7
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17

    
    

    
      
  
Whiteboard: [orange]

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: