Closed
Bug 777274
Opened 12 years ago
Closed 12 years ago
The content of History and Top Sites sections is not cleared when clearing private data
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox15 verified)
VERIFIED
FIXED
Tracking | Status | |
---|---|---|
firefox15 | --- | verified |
People
(Reporter: paul.feher, Assigned: bnicholson)
References
Details
Attachments
(1 file)
1.17 KB,
patch
|
mfinkle
:
review+
akeybl
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
Firefox Mobile Native 15.0b2 build1 (2012-07-24) Device: HTC Desire Z(Android 2.3.3)/HTC Desire (Android 2.2) Steps to reproduce: 1. Load a few pages. 2. Clear private data. Make sure "Browsing&Download History" is selected. 4. Open the Awesome-bar and check the History and Top Sites sections. Expected results: The History and Top Sites sections are empty. Actual results: The records from History and Top Sites sections are still present.
Reporter | ||
Updated•12 years ago
|
tracking-fennec: --- → ?
status-firefox15:
--- → affected
Assignee | ||
Comment 1•12 years ago
|
||
(In reply to Paul Feher from comment #0) > Firefox Mobile Native 15.0b2 build1 (2012-07-24) > Device: HTC Desire Z(Android 2.3.3)/HTC Desire (Android 2.2) > > Steps to reproduce: > 1. Load a few pages. > 2. Clear private data. Make sure "Browsing&Download History" is selected. > 4. Open the Awesome-bar and check the History and Top Sites sections. > > Expected results: > The History and Top Sites sections are empty. > > Actual results: > The records from History and Top Sites sections are still present. Do you have Sync set up? Right now, I think clearing private data only clears local data.
Reporter | ||
Comment 2•12 years ago
|
||
(In reply to Brian Nicholson (:bnicholson) from comment #1) > (In reply to Paul Feher from comment #0) > > Firefox Mobile Native 15.0b2 build1 (2012-07-24) > > Device: HTC Desire Z(Android 2.3.3)/HTC Desire (Android 2.2) > > > > Steps to reproduce: > > 1. Load a few pages. > > 2. Clear private data. Make sure "Browsing&Download History" is selected. > > 4. Open the Awesome-bar and check the History and Top Sites sections. > > > > Expected results: > > The History and Top Sites sections are empty. > > > > Actual results: > > The records from History and Top Sites sections are still present. > > Do you have Sync set up? Right now, I think clearing private data only > clears local data. This happens with a clean profile without any sync account being set up. The local data is not cleared.
Assignee | ||
Comment 4•12 years ago
|
||
Bug 775042 changed the "history" key to "history_downloads". PrivateDataPreference.java wasn't updated for this change, breaking this feature. We didn't need this patch in 16+ because bug 771036 changed the "Sanitize:ClearHistory" message to be fired from JS instead. So for beta, our options are to either land this or bug 771036. Bug 771036 seems like a low risk patch; it might be nice to land that so add-ons can also be fixed.
Assignee: nobody → bnicholson
Status: NEW → ASSIGNED
Attachment #647081 -
Flags: review?(mark.finkle)
Updated•12 years ago
|
Attachment #647081 -
Flags: review?(mark.finkle) → review+
Comment 5•12 years ago
|
||
This patch is drop dead simple, so let's use it for Fx15. Please nom for uplift.
Assignee | ||
Comment 6•12 years ago
|
||
Comment on attachment 647081 [details] [diff] [review] Fix check to clear Java-side history [Approval Request Comment] Bug caused by (feature/regressing bug #): bug 775042 User impact if declined: history cannot be cleared Testing completed (on m-c, etc.): tried locally and it works Risk to taking this patch (and alternatives if risky): low risk, beta only String or UUID changes made by this patch: none
Attachment #647081 -
Flags: approval-mozilla-beta?
Updated•12 years ago
|
Attachment #647081 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Assignee | ||
Comment 7•12 years ago
|
||
http://hg.mozilla.org/releases/mozilla-beta/rev/5d967bdec4a3
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Comment 10•12 years ago
|
||
Verified on Nexus 7 , JB4.1.1, Fennec 15 beta 3.
Status: RESOLVED → VERIFIED
Comment 11•12 years ago
|
||
Also works again on SGS2 with Android 4.0.3.
Updated•12 years ago
|
Updated•10 years ago
|
tracking-fennec: ? → ---
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•