777275 - Private Browsing doesn't remove sessionStore data when user set "Never remember history"

Status: RESOLVED INVALID

(Firefox :: Private Browsing, defect)

Description

[tabmix.onemen]

when user set "Never remember history" from Options > Privacy, the data that was collected by sessionStroe up to this point is not remove.
sessionStore save this data to disk to the file sessionstore.js at the end of the session.
this file with the private data will not remove from the disk as long as Firefox is in auto-started private browsing.

Step to reproduce: 
Tested on clean profile
1. start Firefox on normal browsing
2. make sure browser.startup.page is 3
3. open few tabs.
4. in Options > Privacy set history to "Never remember history"
5. Exit Firefox

Result:
open the profile folder, the file sessionstore.js contain your data from the last session

Comment 1

[(no longer active)]

Why should we remove that information?  We stop recording new information, which is what the user has asked for.

Comment 2

[tabmix.onemen]

from the moment user set "Never remember history" nothing not suppose to save on the disk.
sessionStore saves this data after "Never remember history" already set , at the end of the session.

anyhow the data itself is useless since when in auto-started private browsing sessionStore doesn't load it. the best thing is not save it at all

Comment 3

[(no longer active)]

(In reply to comment #2)
> from the moment user set "Never remember history" nothing not suppose to save
> on the disk.
> sessionStore saves this data after "Never remember history" already set , at
> the end of the session.

Do you see information from where you browsed after turning on "Never remember history" in that file?

Comment 4

[tabmix.onemen]

Yes
all open tabs closed tabs and closed windows from the session before "Never remember history" was set is kept is the file sessionStore.js

Comment 5

[(no longer active)]

Then that's fine.  That file will be used if the user changes their mind in the future to restore their session.