Closed Bug 777304 Opened 12 years ago Closed 12 years ago

const char pointer by get() uses after destructor of NS_ConvertUTF16toUTF8()

Categories

(Core :: General, defect)

Product:
Core
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla17

People

(Reporter: m_kato, Assigned: m_kato)

Details

Attachments

(1 file)

fix
3.74 KB, patch
benjamin
: review+
Details | Diff | Splinter Review 
const char* path = NS_ConvertUTF16toUTF8(str).get() means

NS_ConvertUTF16toUTF8 xxxx(str);
const char *path = xxxx.get();
delete xxxxx.

So path is already free when using it.


There is invalid usages in the following codes.

content/media/webrtc/MediaEngineWebRTCVideo.cpp
dom/bluetooth/linux/BluetoothDBusService.cpp
widget/android/AndroidGraphicBuffer.cpp
Attached patch fix — — Splinter Review 

        Attachment #645990 -
        Flags: review?(benjamin)

    
  

        Attachment #645990 -
        Flags: review?(benjamin) → review+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/5fe4c57fb73e
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: