777524 - Add a=rtcp-mux SDP attribute support to SIPCC

Status: RESOLVED FIXED

(Core :: WebRTC: Signaling, defect)

Description

[enda mannion (:emannion)]

Attachment: Add rtcp-mux SDP attribute support to SIPCC

This patch adds rtcp-mux  SDP attribute support to SIPCC SDP component. Along with the attribute getter and setter.  A boolean is stored in each media struct.  media->rtcp-mux

Comment 1

[Ethan Hugg [:ehugg]]

Comment on attachment 645905 [details] [diff] [review]
Add rtcp-mux SDP attribute support to SIPCC

Review of attachment 645905 [details] [diff] [review]:
-----------------------------------------------------------------

::: media/webrtc/signaling/src/sipcc/core/gsm/gsm_sdp.c
@@ +3702,5 @@
>      char           *session_pwd;
>      cc_action_data_t  data;
>      int             j=0;
> +    int             rtcpmux = 0;
> +    tinybool       *rtcp_mux = FALSE;

Did you mean to make this a pointer?  Seems it should be a bool.

Comment 2

[enda mannion (:emannion)]

Attachment: Revised: Add rtcp-mux SDP attribute support to SIPCC

Updated after applying Ethan's comments.

Comment 3

[Ethan Hugg [:ehugg]]

Pushed to Alder - http://hg.mozilla.org/projects/alder/rev/39cb55f65649

Comment 4

[Ethan Hugg [:ehugg]]

Attachment: Add SDP attribute support to SIPCC

Comment 5

[Ethan Hugg [:ehugg]]

Attachment: Add rtcp-mux SDP attribute support to SIPCC

Comment 6

[Ethan Hugg [:ehugg]]

Pushed to Alder - http://hg.mozilla.org/projects/alder/rev/4a0c4a670a91