777546 - Root the minimum XML stuff necessary to pass jstests

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Steve Fink [:sfink] [:s:]]

I was getting (only) two test failures in e4x stuff. I don't really understand why it isn't puking all over the place, but it appears that those tests will pass with some very minimal rooting.

Comment 1

[Steve Fink [:sfink] [:s:]]

Attachment: Root the minimum XML stuff necessary to pass jstests

Comment 2

[Terrence Cole [:terrence]]

Comment on attachment 645921 [details] [diff] [review]
Root the minimum XML stuff necessary to pass jstests

Review of attachment 645921 [details] [diff] [review]:
-----------------------------------------------------------------

(In reply to Steve Fink [:sfink] from comment #0)
> I was getting (only) two test failures in e4x stuff. I don't really
> understand why it isn't puking all over the place, 

Oh, it does.  Brian added a flag to disable the root analysis if anything touches XML.

> but it appears that those
> tests will pass with some very minimal rooting.

It's a shame we have to muck with this at all.

Comment 3

[Steve Fink [:sfink] [:s:]]

/home/sfink/src/MI-upstream/rev/bdca2e424ca8

Comment 4

[Steve Fink [:sfink] [:s:]]

Oops, sorry about that. Rogue script.

http://hg.mozilla.org/integration/mozilla-inbound/rev/bdca2e424ca8

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/bdca2e424ca8