Closed
Bug 777942
Opened 12 years ago
Closed 12 years ago
Add a label to nsDOMStorage::GetItem()
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
mozilla17
People
(Reporter: jrmuizel, Assigned: jrmuizel)
Details
Attachments
(1 file, 1 obsolete file)
1.44 KB,
patch
|
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
This call can take a long time because it can require main thread IO
Attachment #646353 -
Flags: review?(ehsan)
Updated•12 years ago
|
Attachment #646353 -
Flags: review?(ehsan) → review+
Comment 1•12 years ago
|
||
I asked this before, but have forgotten the answer: how much does a SAMPLE_LABEL slow down performance in release builds?
Comment 2•12 years ago
|
||
...should we sample only the case when I/O is actually needed?
Comment 3•12 years ago
|
||
(In reply to comment #1) > I asked this before, but have forgotten the answer: how much does a > SAMPLE_LABEL > slow down performance in release builds? It creates a SamplerStackFrameRAII object on the stack: http://mxr.mozilla.org/mozilla-central/source/tools/profiler/sps_sampler.h#154
Comment 4•12 years ago
|
||
Comment on attachment 646353 [details] [diff] [review] Add a label to nsDOMStorage::GetItem() (As discussed on IRC, please move this sample to the IO case).
Assignee | ||
Comment 5•12 years ago
|
||
This adds labels for the sqlite and cross process implementations.
Attachment #646353 -
Attachment is obsolete: true
Attachment #646626 -
Flags: review?(ehsan)
Updated•12 years ago
|
Attachment #646626 -
Flags: review?(ehsan) → review+
Assignee | ||
Comment 6•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/38fd00ed7571
Assignee: nobody → jmuizelaar
Comment 7•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/38fd00ed7571
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•