777949 - Make the editor Makefile.in's splendid

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect)

Description

[(no longer active)]

I have a patch which should make the Makefile.in's in editor/ BuildSplendid-friendly!

Comment 1

[(no longer active)]

Attachment: Patch (v1)

Comment 2

[Gregory Szorc [:gps]]

Comment on attachment 646358 [details] [diff] [review]
Patch (v1)

Review of attachment 646358 [details] [diff] [review]:
-----------------------------------------------------------------

::: editor/txmgr/Makefile.in
@@ +18,1 @@
>  endif

We have a TEST_DIRS variable in rules.mk that is essentially:

ifdef ENABLE_TESTS
DIRS += TEST_DIRS
endif

Perhaps we should do something similar for test dirs in the tools tier? Better yet, perhaps we could just change all tests so they execute in the final tier (the tools tier)?

Comment 3

[(no longer active)]

(In reply to comment #2)
> Perhaps we should do something similar for test dirs in the tools tier? Better
> yet, perhaps we could just change all tests so they execute in the final tier
> (the tools tier)?

That makes sense to me.  You're not asking for me to do that in this bug, right?  (I don't know how to do that!)

Comment 4

[Gregory Szorc [:gps]]

(In reply to Ehsan Akhgari [:ehsan] from comment #3)
> (In reply to comment #2)
> > Perhaps we should do something similar for test dirs in the tools tier? Better
> > yet, perhaps we could just change all tests so they execute in the final tier
> > (the tools tier)?
> 
> That makes sense to me.  You're not asking for me to do that in this bug,
> right?  (I don't know how to do that!)

No, I'm not asking you to do it. I'm just planting a seed in the build peers' heads :)

Comment 5

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 646358 [details] [diff] [review]
Patch (v1)

Review of attachment 646358 [details] [diff] [review]:
-----------------------------------------------------------------

::: editor/Makefile.in
@@ +11,5 @@
>  
>  include $(DEPTH)/config/autoconf.mk
>  
> +MODULE           := editor
> +DIRS             := public idl txtsvc libeditor txmgr composer

Can any of these run in parallel?  Do txtsvc, libeditor, txmgr, and composer have dependencies on each other?

Comment 6

[(no longer active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d82321cde733

I'll try to parallelize these directories in another bug.

Comment 7

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/d82321cde733