Closed
Bug 777996
Opened 12 years ago
Closed 11 years ago
mozmill should set focusmanager.testmode
Categories
(Testing Graveyard :: Mozmill, defect)
Testing Graveyard
Mozmill
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: k0scist, Assigned: moijes12)
References
Details
(Whiteboard: [mentor=jhammel][lang=py])
Attachments
(1 file)
|
1.06 KB,
patch
|
k0scist
:
review+
|
Details | Diff | Splinter Review |
see https://bugzilla.mozilla.org/show_bug.cgi?id=758233 this will be removed from the default mozprofile preferences: https://github.com/mozilla/mozbase/blob/master/mozprofile/mozprofile/profile.py#L249 (in fact many of these should be upstreamed, but lets take them one at a time) So Mozmill should set this. Should be easy enough
|
||
Updated•12 years ago
|
Whiteboard: [mentor=jhammel][lang=py]
I haveen't added a check to see whether preferences already contains focusmanager.testmode. I've assumed that when this patch would be applied, the corresponding line from mozrunner would be deleted.
|
|
||
Updated•11 years ago
|
Assignee: nobody → moijes12
Status: NEW → ASSIGNED
|
|
||
Comment 2•11 years ago
|
||
Comment on attachment 722672 [details] [diff] [review] Patch Thank you for the patch. But please do not forget to ask for review from the assigned mentor.
Attachment #722672 -
Flags: review?(jhammel)
|
Reporter | |
Comment 3•11 years ago
|
||
Comment on attachment 722672 [details] [diff] [review] Patch lgtm; as far as i know, double-setting the pref should not cause issues in the case this is landed before the pref is removed from mozrunner
Attachment #722672 -
Flags: review?(jhammel) → review+
|
|
||
Comment 4•11 years ago
|
||
Landed as: https://github.com/mozilla/mozmill/commit/4579ddbf6568efbb1714c1e7a6844e03f3a6a0d3
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
||
Updated•8 years ago
|
Product: Testing → Testing Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•