778042 - Add missing Makefile's to allmakefiles and toolkit-makefiles.sh

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Gregory Szorc [:gps]]

Attachment: More allmakefile coverage, v1

There are a bunch of Makefile's missing from allmakefiles and the like.

khuey gave me verbal permission to land updates. But, I figured it's best to have bugs in case I manage to break things.

The attached patch fixes everything outside of dom/.

Try at http://tbpl.mozilla.org/?tree=Try&rev=fe7b47863623

Comment 1

[Ed Morley [:emorley]]

Presume you are using a script to find these? (I have my old [albeit slightly hacky shell script] knocking about if it is of any use. Has whitelisted makefiles that are mising but never built as part of the main build etc)

Comment 2

[Gregory Szorc [:gps]]

Nope. Ran configure on its own then grepped the output of |make| for "creating".

Comment 3

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 646470 [details] [diff] [review]
More allmakefile coverage, v1

Review of attachment 646470 [details] [diff] [review]:
-----------------------------------------------------------------

I didn't actually look at this.  I assume you know what you're doing.

Comment 4

[Gregory Szorc [:gps]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2fca296bcac8

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/2fca296bcac8