778067 - Re-enable layout/base/crashtests/735943.html when we can support crashed content processes better

Status: RESOLVED WORKSFORME

(Core :: DOM: Core & HTML, defect)

Description

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

See the comment in the upcoming patch.  Attempting to "fix" this is not a good use of resources at the moment, and may lead to other bugs.

The behavior triggered by bug 671196 is good: the parent process gets into a state it can't handle and kills the child process.  The problem is, the reftest harness doesn't know how to restart crashed content processes.  We need that, but bug 671196 is more important right now IMHO.

Comment 1

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Attachment: Disable 735943.html for <browser remote>, for now

See comments in patch.  We should ensure that the mozbrowser window.open setup can handle this edge case.

This also raises the question of how to integrate <iframe mozbrowser> into the reftest harness, which you may want to participate in.  (Swapping it out for <browser remote> should be trivial.)

Comment 2

[Justin Lebar (not reading bugmail)]

Comment on attachment 646491 [details] [diff] [review]
Disable 735943.html for <browser remote>, for now

sgtm

Comment 3

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1b8130ed506c

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/1b8130ed506c

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/99611f9d56e1

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/99611f9d56e1