Closed
Bug 778104
Opened 12 years ago
Closed 12 years ago
NS_IMPL_STRING_ATTR incorrectly uses bool as nsresult
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla17
People
(Reporter: ayg, Assigned: ayg)
References
Details
Attachments
(1 file)
1.61 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
Looks like this is due to bug 742549. NS_IMPL_STRING_ATTR previously called GetAttrHelper, which called GetAttr, ignored the value, and always returned NS_OK. Bug 742549 changed it to return the result of GetAttr, which is a bool, not nsresult.
Comment 1•12 years ago
|
||
Er, oops. SetAttr and GetAttr have different return types... The GetAttr case should just always return NS_OK. Want to patch and I'll review?
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → ayg
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•12 years ago
|
||
Attachment #647115 -
Flags: review?(bzbarsky)
Assignee | ||
Comment 3•12 years ago
|
||
Try: https://tbpl.mozilla.org/?tree=Try&rev=35a0ff8e7053
Comment 4•12 years ago
|
||
Comment on attachment 647115 [details] [diff] [review] Patch r=me
Attachment #647115 -
Flags: review?(bzbarsky) → review+
Assignee | ||
Comment 5•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/ac1975f6837b
Flags: in-testsuite-
Target Milestone: --- → mozilla17
Comment 6•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/ac1975f6837b
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•