Closed
Bug 778105
Opened 12 years ago
Closed 12 years ago
nsOggReader::GetBuffered treats PageSyncResult as nsresult
Categories
(Core :: Audio/Video, defect)
Core
Audio/Video
Tracking
()
RESOLVED
FIXED
mozilla17
People
(Reporter: ayg, Unassigned)
References
Details
Attachments
(1 file)
1009 bytes,
patch
|
cajbir
:
review+
|
Details | Diff | Splinter Review |
There's a "return PAGE_SYNC_ERROR;" in there, added by bug 584615. This is wrong -- PAGE_SYNC_ERROR is equal to 1, which isn't a valid nsresult, and will be interpreted as successful.
Comment 1•12 years ago
|
||
Thanks for filing this bug. Thankfully is return value doesn't propagate all the way up to JS. We hit this case when we detect a page from a stream we've not encountered before (like a new link in a chain or a live stream). I think we can just return NS_OK in this case.
Comment 2•12 years ago
|
||
Attachment #647736 -
Flags: review?(chris.double)
Comment 3•12 years ago
|
||
Comment on attachment 647736 [details] [diff] [review] Patch Review of attachment 647736 [details] [diff] [review]: ----------------------------------------------------------------- ::: content/media/ogg/nsOggReader.cpp @@ +1621,5 @@ > continue; > } > else { > // Page is for a stream we don't know about (possibly a chained > // ogg), return an error. Might want to change the comment since we're no longer returning an error.
Attachment #647736 -
Flags: review?(chris.double) → review+
Comment 4•12 years ago
|
||
With comment changed: https://hg.mozilla.org/integration/mozilla-inbound/rev/3fc0a0b7fdda
Target Milestone: --- → mozilla17
Comment 5•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/3fc0a0b7fdda
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•