778472 - Clean up Java imports

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect, P4)

Comment 1

[Chris Peterson [:cpeterson]]

Attachment: part-1-remove-unused-imports.patch

Part 1: Remove unused and redundant import statements.

Comment 2

[Chris Peterson [:cpeterson]]

Attachment: part-2-replace-wildcard-imports.patch

Part 2: Replace wildcard import statements with fully-qualified names, as per Google's style guide for Android Java code. This makes tracking dependencies and finding unused import statements easier.

https://source.android.com/source/code-style.html#fully-qualify-imports

Comment 3

[Chris Peterson [:cpeterson]]

I have a patch part 3 that cleans up our haphazard ordering of import statements, but I am waiting for feedback from m.d.p.m. re the correct order.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 646892 [details] [diff] [review]
part-1-remove-unused-imports.patch

Are you using a tool to help with this or just eye-balling it? Tools like PMD and FindBugs will find this bad imports too.

Comment 5

[Chris Peterson [:cpeterson]]

(In reply to Mark Finkle (:mfinkle) from comment #4)
> Are you using a tool to help with this or just eye-balling it? Tools like
> PMD and FindBugs will find this bad imports too.

I'm using Checkstyle: http://checkstyle.sourceforge.net/

Comment 6

[Chris Peterson [:cpeterson]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8cad55a9891f
https://hg.mozilla.org/integration/mozilla-inbound/rev/034d26a9a873

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/8cad55a9891f
https://hg.mozilla.org/mozilla-central/rev/034d26a9a873

Comment 8

[Chris Peterson [:cpeterson]]

Attachment: part-3-standardize-import-order.patch

Part 3: Standardize order of import statements from most project-specific to least:

 1. Project-specific imports: org.mozilla
 2. Third-party libraries: com, net, org
 3. System libraries: android
 4. Language features: java

I have an opinion on the order of the imports (most-to-least or least-to-most), but I think any standard is better than none. On m.d.p.m., kats concurred that the most-to-least order was reasonable and no one voiced any other opinions or opposition.

Comment 9

[Chris Peterson [:cpeterson]]

Landed patch 3/3:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d14731ba12c1

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d14731ba12c1