778744 - Middleware code + unit tests cleanup

Status: RESOLVED FIXED

(Socorro Graveyard :: Middleware, defect)

Description

[[DEACTIVATED] Adrian Gaudebert]

There are a few improvements that can be done pretty quickly to the middleware code, first adding the "postgres" attribute to all integration tests, second making check.py happy again. 

Also, there is a few code redundancy that can be removed.

Comment 1

[[DEACTIVATED] Adrian Gaudebert]

As this will come after the new middleware using configman is released, I'll also make a change to use Lars' connection_context class to query Postgresql.

Comment 2

[[DEACTIVATED] Adrian Gaudebert]

This work is waiting for Peter's "configmanization" of the middleware, see https://github.com/mozilla/socorro/pull/811 for status.

Comment 3

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/b52378808dc8d67489d0e99002322d795a3b943b
Fixes bug 778744 - Cleaned up middleware and its unit tests.

https://github.com/mozilla/socorro/commit/aab27dfd3bd24e503b84b85e9c0af7c7763a78ab
bug 778744 - pep 8 cleanup

https://github.com/mozilla/socorro/commit/2f26ffeaef89d4dcdeb6cf657151cbfb8366db81
Merge pull request #1 from Lonnen/778744-pep8

bug 778744 - pep 8 cleanup

https://github.com/mozilla/socorro/commit/b0ddb7534cadb8c2aa432cf21e1370e8542a48ea
Merge pull request #884 from AdrianGaudebert/778744-cleanup-middleware-and-tests

Fixes bug 778744 - Cleaned up middleware and its unit tests.

Comment 4

[Lonnen :lonnen]

This didn't actually make the cut for 24, and is in 25 instead.