779123 - nsDocShell::GetExtendedOrigin returns false instead of NS_OK

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

Bug 776140 added nsDocShell::GetExtendedOrigin, with return value NS_IMETHODIMP.  But it has "NS_ENSURE_TRUE(ssmgr, false)".  This is identical to "NS_ENSURE_TRUE(ssmgr, NS_OK)", but possibly not intended, and at any rate confusing.  Either it should return some type of error, or use NS_OK instead of false.

Comment 1

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

Attachment: Patch, changes false to NS_OK

This is equivalent to the current code, except that it will still work once bug 777292 lands, but was the intent to actually return an error?

Comment 2

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

Comment on attachment 647889 [details] [diff] [review]
Patch, changes false to NS_OK

Sigh, back+forward clears autocomplete=off fields like requestee . . .

Comment 3

[Justin Lebar (not reading bugmail)]

Comment on attachment 647889 [details] [diff] [review]
Patch, changes false to NS_OK

It was likely intended to return an error; can you change it to NS_ERROR_FAILURE?

Comment 4

[Jason Duell]

Yes, it should return NS_ERROR_FAILURE.

Comment 5

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8d9891ef7bcb

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8d9891ef7bcb