779560 - dom/workers/test/test_recursion.html fails on ASan builds

Status: RESOLVED FIXED

(Core :: DOM: Workers, defect)

Description

[Christian Holler (:decoder)]

The mochitest dom/workers/test/test_recursion.html is crashing due to stack space exhaustion (ASan has higher stack space consumption), so I'd like to disable this test, as it's turning mochitest-4 orange on tbpl.

Comment 1

[Christian Holler (:decoder)]

Attachment: Patch

Patch, r=Ms2ger on IRC.

Comment 2

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 648006 [details] [diff] [review]
Patch

Hopefully through IRC chat we've found a different plan of attack here. In general failing tests should not be disabled without a bit of investigation.

Comment 3

[Christian Holler (:decoder)]

Yep, I'm compiling with some modifications right now to see whats the best solution here. Overall, we wouldn't care about the test failure right now if it was not easy to solve, since we have other stuff with higher priority on these builds. But I think what we discussed on IRC will work :) Will update this bug once testing is complete.

Comment 4

[Christian Holler (:decoder)]

Attachment: Updated patch

This patch reverts the ASan specific stack limit for workers in RuntimeService.cpp. With this change, all dom/workers/ tests are green on ASan, but compared to normal builds, ASan builds will be able to perform less recursive calls with workers. That is no immediate problem right now for ASan builds though.

Comment 5

[Christian Holler (:decoder)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1a3111e8b478

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/1a3111e8b478