779696 - Sync 1.1: MetLog-related errors running 'make test'

Status: VERIFIED FIXED

(Cloud Services Graveyard :: Server: Sync, defect)

Description

[James Bonacci [:jbonacci]]

So, after the usual steps to get this installed:
$ hg clone https://hg.mozilla.org/services/server-full
$ cd server-full
$ make build


I now see this:
$ make test
bin/nosetests -s --with-xunit deps/server-core/services/tests deps/server-reg/syncreg/tests deps/server-storage/syncstorage/tests
...............................................................................S.S..S................................................................................................EE..................
======================================================================
ERROR: test_addl_services_data (syncstorage.tests.test_metlog.TestMetlog)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/opt/sync/server-full/deps/server-storage/syncstorage/tests/test_metlog.py", line 94, in test_addl_services_data
    expected['req_time'] = msg2['fields']['req_time']
KeyError: 'req_time'

======================================================================
ERROR: test_stats_go_out (syncstorage.tests.test_metlog.TestMetlog)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/opt/sync/server-full/deps/server-storage/syncstorage/tests/test_metlog.py", line 64, in test_stats_go_out
    self.assertEqual(msg2['fields']['userid'], self.username)
KeyError: 'userid'

----------------------------------------------------------------------
Ran 201 tests in 65.060s

FAILED (SKIP=3, errors=2)
make: *** [test] Error 1


Not sure I remember the SKIPs being there either. I will need to regress on an older install...



IRC Snippet:
17:23 < rfkelly> ah, these look very similar to the ones reported by a user in #sync the other day
17:28 < RaFromBRC> ah, i think that's my fault maybe
17:28 < RaFromBRC> code changed and i forgot the tests
17:28 < RaFromBRC> which means i didn't run them... bad code monkey

Comment 1

[Rob Miller [:rmiller]]

Okay, turns out the tests were right, but server-full is maybe pulling down the wrong version of server-core. You should be able to get the tests passing by cd'ing into deps/server-core and running `hg pull; hg up`, then cd'ing back to the top of the install and trying again.

I'll work on fixing the build so fresh checkouts will work.

Comment 2

[Ryan Kelly [:rfkelly]]

Building with CHANNEL=dev gets rid of the errors.  It looks like the change from Bug 772716 is included in a release tag of server-storage, but is not yet in a release tag for server-core.

I've gone ahead and tagged rpm-2.10-2 to include the metlog changes, this seems to fix the errors for me.

Comment 3

[Ryan Kelly [:rfkelly]]

server-full now builds and tests cleanly for me, several skipped tests but no failures.  Marking fixed.

Comment 4

[James Bonacci [:jbonacci]]

Verified as fixed.