Closed Bug 779721 Opened 12 years ago Closed 12 years ago

Simplify MediaStreamGraph

Categories

(Core :: Audio/Video, defect)

x86_64
Windows 7
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla17

People

(Reporter: roc, Assigned: roc)

References

Details

Attachments

(6 files)

Blocks: 779715
No longer depends on: 779715
The IsDestroyed() getter will come in handy later for future patches, too.
Attachment #648597 - Flags: review?(rjesup)
Comment on attachment 648210 [details] [diff] [review]
Part 1: simplify invariants around when messages are processed

Review of attachment 648210 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/media/MediaStreamGraph.cpp
@@ +895,3 @@
>      LOG(PR_LOG_DEBUG, ("Media graph %p computed blocking for interval %f to %f",
> +                       this, MediaTimeToSeconds(mStateComputedTime),
> +                       MediaTimeToSeconds(end)));                       

trailing whitespace
Attachment #648210 - Flags: review?(rjesup) → review+
Attachment #648211 - Flags: review?(rjesup) → review+
Attachment #648212 - Flags: review?(rjesup) → review+
Attachment #648213 - Flags: review?(rjesup) → review+
Comment on attachment 648214 [details] [diff] [review]
Part 5: Add a comment explaining more about how MediaStream lifetimes are managed

Review of attachment 648214 [details] [diff] [review]:
-----------------------------------------------------------------

I like the lifetime description!  Everything should have one... :-)
Attachment #648214 - Flags: review?(rjesup) → review+
Comment on attachment 648597 [details] [diff] [review]
Part 6: Check that Destroy is the last message sent from the main thread for a stream

Review of attachment 648597 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me - I debugged through one these quite a bit; this makes it easier to try to flag and trigger on
Attachment #648597 - Flags: review?(rjesup) → review+
Depends on: 790854
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: