Closed
Bug 779721
Opened 12 years ago
Closed 12 years ago
Simplify MediaStreamGraph
Categories
(Core :: Audio/Video, defect)
Tracking
()
RESOLVED
FIXED
mozilla17
People
(Reporter: roc, Assigned: roc)
References
Details
Attachments
(6 files)
29.96 KB,
patch
|
jesup
:
review+
|
Details | Diff | Splinter Review |
1.19 KB,
patch
|
jesup
:
review+
|
Details | Diff | Splinter Review |
2.96 KB,
patch
|
jesup
:
review+
|
Details | Diff | Splinter Review |
3.03 KB,
patch
|
jesup
:
review+
|
Details | Diff | Splinter Review |
2.08 KB,
patch
|
jesup
:
review+
|
Details | Diff | Splinter Review |
5.33 KB,
patch
|
jesup
:
review+
|
Details | Diff | Splinter Review |
This is in preparation for bug 779715.
Assignee | ||
Updated•12 years ago
|
Assignee | ||
Comment 1•12 years ago
|
||
Attachment #648210 -
Flags: review?(rjesup)
Assignee | ||
Comment 2•12 years ago
|
||
Attachment #648211 -
Flags: review?(rjesup)
Assignee | ||
Comment 3•12 years ago
|
||
Attachment #648212 -
Flags: review?(rjesup)
Assignee | ||
Comment 4•12 years ago
|
||
Attachment #648213 -
Flags: review?(rjesup)
Assignee | ||
Comment 5•12 years ago
|
||
Attachment #648214 -
Flags: review?(rjesup)
Assignee | ||
Comment 6•12 years ago
|
||
The IsDestroyed() getter will come in handy later for future patches, too.
Attachment #648597 -
Flags: review?(rjesup)
Comment 7•12 years ago
|
||
Comment on attachment 648210 [details] [diff] [review] Part 1: simplify invariants around when messages are processed Review of attachment 648210 [details] [diff] [review]: ----------------------------------------------------------------- ::: content/media/MediaStreamGraph.cpp @@ +895,3 @@ > LOG(PR_LOG_DEBUG, ("Media graph %p computed blocking for interval %f to %f", > + this, MediaTimeToSeconds(mStateComputedTime), > + MediaTimeToSeconds(end))); trailing whitespace
Attachment #648210 -
Flags: review?(rjesup) → review+
Updated•12 years ago
|
Attachment #648211 -
Flags: review?(rjesup) → review+
Updated•12 years ago
|
Attachment #648212 -
Flags: review?(rjesup) → review+
Updated•12 years ago
|
Attachment #648213 -
Flags: review?(rjesup) → review+
Comment 8•12 years ago
|
||
Comment on attachment 648214 [details] [diff] [review] Part 5: Add a comment explaining more about how MediaStream lifetimes are managed Review of attachment 648214 [details] [diff] [review]: ----------------------------------------------------------------- I like the lifetime description! Everything should have one... :-)
Attachment #648214 -
Flags: review?(rjesup) → review+
Comment 9•12 years ago
|
||
Comment on attachment 648597 [details] [diff] [review] Part 6: Check that Destroy is the last message sent from the main thread for a stream Review of attachment 648597 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me - I debugged through one these quite a bit; this makes it easier to try to flag and trigger on
Attachment #648597 -
Flags: review?(rjesup) → review+
Assignee | ||
Comment 10•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/51de5c54e500 https://hg.mozilla.org/integration/mozilla-inbound/rev/28860e96d78d https://hg.mozilla.org/integration/mozilla-inbound/rev/cecd42ed7943 https://hg.mozilla.org/integration/mozilla-inbound/rev/409c0d581dcd https://hg.mozilla.org/integration/mozilla-inbound/rev/cdf37b6a641a https://hg.mozilla.org/integration/mozilla-inbound/rev/2e9222b7cfcc
Comment 11•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/51de5c54e500 https://hg.mozilla.org/mozilla-central/rev/28860e96d78d https://hg.mozilla.org/mozilla-central/rev/cecd42ed7943 https://hg.mozilla.org/mozilla-central/rev/409c0d581dcd https://hg.mozilla.org/mozilla-central/rev/cdf37b6a641a https://hg.mozilla.org/mozilla-central/rev/2e9222b7cfcc
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in
before you can comment on or make changes to this bug.
Description
•