Closed
Bug 779735
Opened 12 years ago
Closed 12 years ago
Async pan/zoom broken
Categories
(Core :: Graphics: Layers, defect)
Core
Graphics: Layers
Tracking
()
People
(Reporter: cjones, Assigned: cjones)
References
Details
Attachments
(1 file)
1.69 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
It don't work. E/GeckoConsole( 1004): [JavaScript Error: "viewport is null" {file: "chrome://global/content/BrowserElementChild.js" line: 867}] which is _recvViewportChange: function(data) { let viewport = data.json; and the data originates from TabChild::RecvUpdateFrame(const nsIntRect& aDisplayPort, [snip] { nsCString data; data += nsPrintfCString("{ \"x\" : %d", aScrollOffset.x); data += nsPrintfCString(", \"y\" : %d", aScrollOffset.y); [snip] return RecvAsyncMessage(NS_LITERAL_STRING("Viewport:Change"), NS_ConvertUTF8toUTF16(data)); (Yes, this is terrible.) So it looks like the mm API changed, no longer |.json|, or our manually-built string isn't a valid structured clone.
Assignee | ||
Comment 1•12 years ago
|
||
Confirmed that https://hg.mozilla.org/integration/mozilla-inbound/rev/b83188166929 works.
Comment 2•12 years ago
|
||
I did mention at some point that I may or may not break that method - but since there are no tests for it, had to guess. Apparently I did break it. Someone who knows how to test the functionality needs to fix it (and add tests!).
Assignee | ||
Comment 3•12 years ago
|
||
Assignee: nobody → jones.chris.g
Attachment #648286 -
Flags: review?(bugs)
Comment 4•12 years ago
|
||
Comment on attachment 648286 [details] [diff] [review] Fix up shim code supporting hack to deliver mm message from C++ Uh. sorry! And thanks for fixing this. Any chance to get some kind of test for this?
Attachment #648286 -
Flags: review?(bugs) → review+
Updated•12 years ago
|
blocking-basecamp: --- → ?
Assignee | ||
Comment 5•12 years ago
|
||
This is a bustage fix, blocker. https://hg.mozilla.org/integration/mozilla-inbound/rev/be31a4c795f7
blocking-basecamp: ? → +
Assignee | ||
Comment 6•12 years ago
|
||
(In reply to Olli Pettay [:smaug] from comment #4) > Comment on attachment 648286 [details] [diff] [review] > Fix up shim code supporting hack to deliver mm message from C++ > > Any chance to get some kind of test for this? Yes. The situation is complicated, sadly.
Comment 7•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/be31a4c795f7
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in
before you can comment on or make changes to this bug.
Description
•