Closed
Bug 780262
Opened 12 years ago
Closed 11 years ago
Context ui fails to dismiss after selecting an item from autocomplete
Categories
(Firefox for Metro Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jimm, Assigned: jimm)
Details
(Whiteboard: completed-elm)
Attachments
(1 file)
12.49 KB,
patch
|
jwilde
:
review+
|
Details | Diff | Splinter Review |
For landing on elm. I also added some header commenting.
Assignee | ||
Updated•12 years ago
|
Attachment #648823 -
Flags: review?(jonathan)
Comment 1•12 years ago
|
||
Comment on attachment 648823 [details] [diff] [review] patch Review of attachment 648823 [details] [diff] [review]: ----------------------------------------------------------------- Looks great. Only comments I have are directed more at myself in regards to the ContextUIHelper's design. Right now, the current way that we have partial visibility of ContextUI is by breaking encapsulation of ContextUIHelper and directly setting its visibility status. I'm wondering whether it would make things easier to follow if I put in getters and setters for ContextUIHelper's isExpanded and isVisible properties that automatically fire ContextUI events when they're set and then have a separate method for setting partial visibility. But, that might be overcomplicating things for the time being.
Attachment #648823 -
Flags: review?(jonathan) → review+
Assignee | ||
Comment 2•12 years ago
|
||
https://hg.mozilla.org/projects/elm/rev/18bb4a6a079b
Whiteboard: completed-elm
Assignee | ||
Updated•12 years ago
|
Component: Location Bar → General
Product: Firefox → Firefox for Metro
Comment 3•11 years ago
|
||
Resolving bugs in the Firefox for Metro product that are fixed on the elm branch. Sorry for the bugspam. Search your email for "bugspam-elm" if you want to find and delete all of these messages at once.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Updated•10 years ago
|
OS: Windows 8 Metro → Windows 8.1
You need to log in
before you can comment on or make changes to this bug.
Description
•