780340 - Allow compositor-drive animation of visibility

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[David Zbarsky (:dzbarsky)]

Visibility does not actually affect the animation, since the element is always visible except for possibly the start and end states.  When the element is hidden, that is handled by layout.  This allows transitions like http://beta.timc.idv.tw/test2.html to be async.

Comment 1

[David Zbarsky (:dzbarsky)]

Attachment: Patch

Comment 2

[Ed Morley [:emorley]]

Backed out as part of the mass tree revert due to bustage caused by other landings:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c801b99d726f

Once the tree is open again, this can reland :-)

Comment 3

[David Zbarsky (:dzbarsky)]

Relanded: https://hg.mozilla.org/integration/mozilla-inbound/rev/3f0298834ad9

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/3f0298834ad9

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

What if it's a CSS animation involving keyframes, and the visibility state needs to change somewhere in the middle due to what's specified in the keyframes (or due to repetition from animation-iteration-count)?

Comment 6

[David Zbarsky (:dzbarsky)]

Are you talking about something like http://pastebin.mozilla.org/1740884?
That doesn't work in Firefox currently.  In my testing, I could only get visibility to work for transitions, never for animations.

However, in theory since the animation is also sampled by the main thread, layout will set the frame invisible if it needs to, which will rebuild the layer tree.

Comment 7

[David Zbarsky (:dzbarsky)]

So when I fix the 30%% thing, it does actually work as expected, even with async animations, because of what I said in my previous comment.

Comment 8

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Maybe that's because we're not doing anything to suppress the animation running normally in addition to running on the compositor thread?  But once we do, won't it be a problem?

Comment 9

[David Zbarsky (:dzbarsky)]

That is correct.  At that point we can just sample the visibility on the compositor and set a scale(0,0) transform matrix on the layer if it should be invisible.  Or do you think we should do that now?

Comment 10

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

This was backed out in bug 784239 (which is good, I think).