780367 - java.lang.IllegalStateException: ScrollView can host only one direct child at android.widget.ScrollView.addView(ScrollView.java)

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Scoobidiver (away)]

It has been it by 4 users since 17.0a1/20120803. The regression range is:
hg.mozilla.org/mozilla-central/pushloghtml?fromchange=588424024294&tochange=89dcadd42ec4
It's likely a regression from bug 686528.

Here is a crash report: bp-a2eff7a4-6e88-4876-a39e-4e63a2120804.

java.lang.IllegalStateException: ScrollView can host only one direct child
	at android.widget.ScrollView.addView(ScrollView.java:241)
	at android.view.LayoutInflater.rInflate(LayoutInflater.java:743)
	at android.view.LayoutInflater.inflate(LayoutInflater.java:459)
	at android.view.LayoutInflater.inflate(LayoutInflater.java:396)
	at android.view.LayoutInflater.inflate(LayoutInflater.java:352)
	at org.mozilla.gecko.AboutHomeContent.inflate(AboutHomeContent.java:143)
	at org.mozilla.gecko.AboutHomeContent.init(AboutHomeContent.java:111)
	at org.mozilla.gecko.BrowserApp$AboutHomeRunnable.run(BrowserApp.java:528)
	at android.os.Handler.handleCallback(Handler.java:605)
	at android.os.Handler.dispatchMessage(Handler.java:92)
	at android.os.Looper.loop(Looper.java:137)
	at android.app.ActivityThread.main(ActivityThread.java:4424)
	at java.lang.reflect.Method.invokeNative(Native Method)
	at java.lang.reflect.Method.invoke(Method.java:511)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:784)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:551)
	at dalvik.system.NativeStart.main(Native Method)

More reports at:
https://crash-stats.mozilla.com/report/list?signature=java.lang.IllegalStateException%3A+ScrollView+can+host+only+one+direct+child+at+android.widget.ScrollView.addView%28ScrollView.java%29

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

I saw this error while creating the patches in bug 686528. I thought I fixed it with removeAllViews() but I will investigate.

Comment 2

[Scoobidiver (away)]

It's #4 top crasher over the last 3 days.

Comment 3

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Affected for 17.

Comment 4

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: Patch

After an OOM cleanup of BrowerApp, AboutHomeContent.inflate() would get called in AboutHomeContent.onConfigurationChanged() before AboutHomeContent.init() was called from BrowserApp.

Made GeckoApp/BrowserApp call inflate() instead of onConfigurationChanged() to ensure it's only called after init() is.

Comment 5

[Sriram Ramasubramanian [:sriram]]

Comment on attachment 649415 [details] [diff] [review]
Patch

Review of attachment 649415 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/fad487db4ea9

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/fad487db4ea9

Comment 8

[Sriram Ramasubramanian [:sriram]]

Comment on attachment 649415 [details] [diff] [review]
Patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 686528
User impact if declined: Inflation of about:home will crash at times.
Testing completed (on m-c, etc.): Landed in m-c on 08/07
Risk to taking this patch (and alternatives if risky): None.
String or UUID changes made by this patch: None.

Comment 9

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 649415 [details] [diff] [review]
Patch

Approving for Aurora but can someone please confirm if 15 is affected by this?

Comment 10

[Scoobidiver (away)]

(In reply to Lukas Blakk [:lsblakk] from comment #9)
> Approving for Aurora but can someone please confirm if 15 is affected by
> this?
Aurora and Beta are currently unaffected, but will be once bug 686528 lands in branches.

Comment 11

[Sriram Ramasubramanian [:sriram]]

As mentioned in comment #10, to land bug 686528 in beta, I would need approval for this.

Comment 12

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 649415 [details] [diff] [review]
Patch

approving then, for Beta, please make sure all this lands today so that it goes into Beta 5 and we have time to make sure there aren't any serious regressions for this.

Comment 13

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Please note that the patches in bug 686528 should land before this patch (and the patch in bug 780481 should also land in this series).

Comment 14

[Ryan VanderMeulen [:RyanVM]]

This didn't apply cleanly to aurora, but the unbitrotting was pretty mechanical. That said, please look it over to make sure I didn't mess anything up.

https://hg.mozilla.org/releases/mozilla-aurora/rev/0000a76dc267

https://hg.mozilla.org/releases/mozilla-beta/rev/acf8046887e0

Comment 15

[Ryan VanderMeulen [:RyanVM]]

This had to be backed out due to bustage from bug 686528.

https://hg.mozilla.org/releases/mozilla-aurora/rev/1b8af79d5194
https://hg.mozilla.org/releases/mozilla-beta/rev/09e2ae313229

Comment 16

[Sriram Ramasubramanian [:sriram]]

Pushed to beta: https://hg.mozilla.org/releases/mozilla-beta/rev/d6cbf07e54ed

Comment 17

[Sriram Ramasubramanian [:sriram]]

And to aurora: https://hg.mozilla.org/releases/mozilla-aurora/rev/e3985167ea1d

Comment 18

[Cristian Nicolae (:xti)]

The last crash occurred almost a week ago on 17.0a1 build. I cannot reproduce it on any branch. Closing bug as verified fixed.

--
Device: Galaxy Note
OS: Android 4.0.4