780390 - right mouse does not bring up Google Maps context menu

Status: RESOLVED INCOMPLETE

(Camino Graveyard :: Toolbars & Menus, defect)

Description

[Mark Asbach]

I'm reporting a bug for Camino 1.9.2.28 20120308211433

This seems to be an issue fixed in Firefox 7; could you please verify by comparing ticket https://bugzilla.mozilla.org/show_bug.cgi?id=426643 ?

Regression:
- open http://maps.google.com
- right click somewhere on the map and be sure to use a physical right mouse button or the two-finger gesture on the trackpad

A context menu should appear, but is does not. Reproducible 100%.

Interestingly enough, CTRL + left click works, so it seems to be a Cocoa GUI issue.

What really strikes me is that this is a commonly used feature on a broadly used web app ... must have been reported, shouldn't it?

Thank you very much for looking into this issue.

Comment 1

[Chris Lawson (gone)]

I'm pretty sure this is a bug on Google's end; I've been seeing something similar to this with my (programmable) mouse for a while now, and it suddenly quit working without any major changes in Camino. I suspect Google broke something for Gecko 1.9.x browsers, probably on purpose, and I doubt there's going to be anything anyone can do to get them to fix it.

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

If I'm reading things right, this is a dupe of bug 426643 (on which both Chris and I commented back in the day), so this has never worked right in Camino/Cocoa Widgets.

The patch is fairly trivial, so it would be easy to backport to the CAMINO_2_1_SECBRANCH for Camino 2.1.3, but I'm very concerned about possible regressions, and I don't have much time to try and test things, nor do we have a very good suite of ctrl-/right-click and context menu "things to test" to begin with.

That said, from the blame, it looks like those lines were intended to fix bug 158345, and the fix doesn't regress that, at least in Flash 10.3.

Comment 3

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(Someone remind me to spin a test build for this; if we get a few people using the test build for a while with no reports of new problems/regressions, I'm inclined to take the backport on our branch.)

Comment 4

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: backported patch

Here's the patch; it was sitting in my Gecko tree from my testing back in August, and I need my Gecko tree clean right now…

Comment 5

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to Smokey Ardisson (offline for a while; not following bugs - do not email) from comment #3)
> (Someone remind me to spin a test build for this; if we get a few people
> using the test build for a while with no reports of new
> problems/regressions, I'm inclined to take the backport on our branch.)

The test build in bug 825484 comment 6 includes this patch, for ease-of-testing.

Comment 6

[Mark Asbach]

> The test build in bug 825484 comment 6 includes this patch, for
> ease-of-testing.

For the sake of completeness: I can confirm that this bug is fixed with the cited patch. See comment there. Thanks!

Comment 7

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to Mark Asbach from comment #6)
> > The test build in bug 825484 comment 6 includes this patch, for
> > ease-of-testing.
> 
> For the sake of completeness: I can confirm that this bug is fixed with the
> cited patch. See comment there. Thanks!

Thanks.

While it's good to have independent confirmation that the patch works, what I'm most concerned with is that no other right-mouse behaviors have broken inadvertently (because our Camino code was relying on the old behavior for whatever reason).