780431 - Add-ons set to AUTOUPDATE_DISABLE should not show automatic updates UI

Status: RESOLVED INVALID

(Toolkit :: Add-ons Manager, defect)

Description

[Jason Barnabe (np)]

Stylish adds add-on items with applyBackgroundUpdates = AddonManager.AUTOUPDATE_DISABLE. Despite this, Firefox shows the Automatic Updates : Default/On/Off UI in the page for the add-on item in the add-ons manager. This UI should be hidden if applyBackgroundUpdates is set as such.

To reproduce:

1. Install Stylish - https://addons.mozilla.org/en-US/firefox/addon/stylish/
2. Go to userstyles.org, install any style.
3. Go to the add-ons manager.
4. Go to the User Styles panel.
5. Click More for the entry of the user style you installed.
6. Notice Automatic Updates UI.

Comment 1

[Jason Barnabe (np)]

Or maybe I'm misunderstanding this parameter. Is this supposed to represent what the developer wants to happen with the item, or is it supposed to represent the user's choice in the UI? If the latter, is it expected that the add-on item provider would be storing the user's choice (as opposed to Firefox itself remembering it)?

Comment 2

[Blair McBride [:Unfocused] (UNAVAILABLE)]

That UI maps to the applyBackgroundUpdates property - it's a user-setting (though I guess the provider can give it a default other than AUTOUPDATE_DEFAULT). And yes, the provider is expected to store that value when its set.

Comment 3

[Jason Barnabe (np)]

Thanks for the info. I've got it working correctly now and I've updated https://developer.mozilla.org/en-US/docs/Addons/Add-on_Manager/Addon .