780693 - IPC VolumeManager on Gonk

Status: RESOLVED FIXED

(Core Graveyard :: Widget: Gonk, defect)

Description

[Doug Turner (:dougt)]

Attachment: patch v.1

This patch forwards notifications from the volume manager to the child process.
It also allow you to synchronously learn about the status of a give named volume.

David and I both touched this patch.  Kyle, can you look at this?

Comment 1

[Doug Turner (:dougt)]

Comment on attachment 649370 [details] [diff] [review]
patch v.1

not the right patch.

Comment 2

[Doug Turner (:dougt)]

Attachment: patch v.1

Comment 3

[Doug Turner (:dougt)]

Attachment: patch v.2

without that sync method

Comment 4

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 650678 [details] [diff] [review]
patch v.2

Review of attachment 650678 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/system/gonk/Makefile.in
@@ +69,5 @@
>    $(NULL)
>  # for our local copy of AudioSystem.h
>  LOCAL_INCLUDES += -I$(topsrcdir)/media/libsydneyaudio/src
> +
> +EXPORTS     = \

Nit: too much whitespace there.

Comment 5

[Doug Turner (:dougt)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5334f92a9f34

Comment 6

[:Benjamin Peterson]

I rearranged the ContentChild constructor to fix warnings-as-errors:

https://hg.mozilla.org/integration/mozilla-inbound/rev/14c4b37f9a0e

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/5334f92a9f34

Comment 8

[Ryan VanderMeulen [:RyanVM]]

And the follow-up:
https://hg.mozilla.org/mozilla-central/rev/14c4b37f9a0e