781274 - Enable StrictMode's red screen flashing on unofficial builds

Status: RESOLVED WONTFIX

(Firefox for Android Graveyard :: General, defect, P3)

Description

[Chris Peterson [:cpeterson]]

Attachment: enable-StrictMode-penaltyFlashScreen.patch

Starting with Honeycomb, StrictMode can flash a red rectangle to warn violations: 

  http://developer.android.com/reference/android/os/StrictMode.ThreadPolicy.Builder.html#penaltyFlashScreen%28%29

More annoying warning options include crashing or a (non-fatal) dialog box. But I think these are too aggressive.

We currently enable StrictMode in unofficial builds: local, Nightly, and Aurora.

Comment 1

[Chris Peterson [:cpeterson]]

Green tryserver run:
https://tbpl.mozilla.org/?tree=Try&rev=6db4694cc2bf

Comment 2

[Chris Peterson [:cpeterson]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a1c1113cdf3e

Comment 3

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/a1c1113cdf3e

Comment 4

[Chris Peterson [:cpeterson]]

Comment on attachment 650215 [details] [diff] [review]
enable-StrictMode-penaltyFlashScreen.patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): N/A
User impact if declined: None. This is a debugging feature that only activates itself in Nightly and Aurora builds.
Testing completed (on m-c, etc.): m-c
Risk to taking this patch (and alternatives if risky): Low risk. This debugging feature already exists; my patch just tweaks how it works on Android >= Honeycomb.
String or UUID changes made by this patch: N/A

Comment 5

[Chris Peterson [:cpeterson]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/a7e88d150acb

Comment 6

[Chris Peterson [:cpeterson]]

I backed out of m-a because, after some discussion, I think this will cause more user confusion than it's worth.
https://hg.mozilla.org/releases/mozilla-aurora/rev/2129954bde52

Comment 7

[Chris Peterson [:cpeterson]]

I backed out of m-c, too.
https://hg.mozilla.org/mozilla-central/rev/16932b475002