781331 - Hook up systemXHR to permissions manager

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Comment 1

[Gregor Wagner [:gwagner]]

Attachment: patch

Comment 2

[Gregor Wagner [:gwagner]]

Attachment: patch

Comment 3

[Gregor Wagner [:gwagner]]

Comment on attachment 650324 [details] [diff] [review]
patch

Uh I also have to change some tests.

Comment 4

[Philipp von Weitershausen [:philikon]]

(In reply to Gregor Wagner [:gwagner] from comment #3)
> Uh I also have to change some tests.

Yes you do. Also I'm pretty sure I'm not qualified to review this.

Comment 5

[Gregor Wagner [:gwagner]]

Attachment: patch

Comment 6

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 650396 [details] [diff] [review]
patch

Review of attachment 650396 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/base/src/nsXMLHttpRequest.cpp
@@ +581,5 @@
> +      return;
> +
> +    PRUint32 permission;
> +    nsresult rv =
> +      permMgr->TestPermissionFromPrincipal(principal, "systemXHR", &permission);

I think we should use the same permission as for raw TCP sockets here. I'm not sure if we decided a name for that, but something like "networktcp" or some such would work for me.

@@ +586,5 @@
> +    if (NS_FAILED(rv)) {
> +      return;
> +    }
> +
> +    if (permission != nsIPermissionManager::ALLOW_ACTION) {

Just merge these two if-statements.

Comment 7

[Gregor Wagner [:gwagner]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/07d5886658b2

Comment 8

[Gregor Wagner [:gwagner]]

(In reply to Jonas Sicking (:sicking) from comment #6)
> Comment on attachment 650396 [details] [diff] [review]
> patch
> 
> Review of attachment 650396 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: content/base/src/nsXMLHttpRequest.cpp
> @@ +581,5 @@
> > +      return;
> > +
> > +    PRUint32 permission;
> > +    nsresult rv =
> > +      permMgr->TestPermissionFromPrincipal(principal, "systemXHR", &permission);
> 
> I think we should use the same permission as for raw TCP sockets here. I'm
> not sure if we decided a name for that, but something like "networktcp" or
> some such would work for me.

Followup bug 783716 because that needs gaia changes.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/07d5886658b2

Comment 10

[Jim Porter (:squib)]

With this patch, what's the recommended way to enable systemXHR for testing purposes (on localhost)?