781390 - Make barrier verifier testing work better with the methodjit

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Attachment: patch

While looking at bug 774859, I was trying to write a test case using the write barrier verifier and the methodjit. However, it turns out to be almost impossible to do that. We're supposed to invoke the operation callback in the methodjit when running with gczeal(4). However, each time we call StartVerifyPreBarriers, it calls setNeedsBarrier, which causes us to return to the interpreter.

This patch makes testing a little easier by always compiling with barriers when gczeal==4. That way we don't have to return to the interpreter each time we do Start/EndVerifyPreBarriers.

Comment 1

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/07f21ec5d516

Comment 2

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/07f21ec5d516

Comment 3

[Ian Neal]

Looks like this (or a subset of) needs to be landed on mozilla-aurora to prevent bustage by the landing of the patch from bug 774859