Closed
Bug 781403
Opened 12 years ago
Closed 12 years ago
cull "performance" jstests
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla17
People
(Reporter: Benjamin, Unassigned)
Details
Attachments
(1 file)
|
25.07 KB,
patch
|
dmandelin
:
review+
|
Details | Diff | Splinter Review |
Most of these, like js1_5/Regress/regress-169559.js (which checks that global access is less than 2.5 times slower than local access), are useless. They should be examined and killed as necessary.
|
||
Comment 1•12 years ago
|
||
Yes, please. I would be surprised if most of them haven't been turned off already.
|
Reporter | |
Comment 2•12 years ago
|
||
Here is a patch removing all the tests that test BigO behavior. Of performance.tests, I left two leak tests and one of Date resolution. In theory, I suppose the leak tests are still applicable, but they definitely take a long time to run. Don't know about Date resolution. Comments welcome.
Attachment #650416 -
Flags: review?(dmandelin)
|
|
Reporter | |
Comment 3•12 years ago
|
||
My favorite is one that tests that decompilation is quadratic. :)
|
||
Updated•12 years ago
|
Attachment #650416 -
Flags: review?(dmandelin) → review+
|
|
Reporter | |
Comment 4•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/a3c509c4d315
|
||
Comment 5•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/a3c509c4d315
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in
before you can comment on or make changes to this bug.
Description
•