781464 - Do not add stack to result if assertion passes

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

See bug 781376 for the fix in Mozmill 2.0 base. We need the same for our Mozmill tests which we run for 1.5. So this bug will cover the fix in the mozmill-tests repository.

With this patch our reports will become way smaller and take lesser space in the db.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Patch v1

Simply and easy to understand fix. Vlad, can you please review given that Dave is not available atm? Thanks

Comment 2

[Maniac Vlad Florin (:vladmaniac)]

Comment on attachment 650473 [details] [diff] [review]
Patch v1

Fairly an r+

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Just for comparison, the numbers speak themselves:

-rw-r--r--@  1 henrik  staff  264310 Aug  9 11:26 new.txt
-rw-r--r--@  1 henrik  staff  728381 Aug  9 11:27 old.txt

It's a reduction of 64% in size of a report.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Landed on default:
http://hg.mozilla.org/qa/mozmill-tests/rev/797913f70234

Lets wait for todays testrun on 17.0 and then we should backport.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Landed on older branches:
http://hg.mozilla.org/qa/mozmill-tests/rev/ce8dcb9914f0 (aurora)
http://hg.mozilla.org/qa/mozmill-tests/rev/76fab8b7da75 (beta)
http://hg.mozilla.org/qa/mozmill-tests/rev/d6b404df056f (release)
http://hg.mozilla.org/qa/mozmill-tests/rev/69dc19050dfb (esr10)