Closed Bug 781845 Opened 12 years ago Closed 12 years ago

GCLI should support 'then-able' promises instead of checking d.isPromise (#58)

Categories

(DevTools :: Console, defect, P3)

Product:
DevTools
Component:
Console
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Firefox 17

People

(Reporter: jwalker, Unassigned)

Details

In cli.js (around line 1075) the check on the return type for a promise is currently ...

 if (reply != null && reply.isPromise)

This is fine for the built-in context.createPromise() but could be made to work with all then-able promises by using...

 if (reply && typeof reply.then === 'function')

---
See also
https://github.com/mozilla/gcli/issues/58
Priority: -- → P3
Target Milestone: --- → Firefox 17
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.