781851 - [shipping] clean up Milestone.status and redirect shortcut use

Status: RESOLVED FIXED

(Webtools Graveyard :: Elmo, defect, P5)

Description

[Peter Bengtsson [:peterbe]]

The views code in shipping uses http.HttpRedirect() instead of the redirect() shortcut.

Instead of things like status=Milestone.OPEN it does things like status=1.

Comment 1

[Peter Bengtsson [:peterbe]]

Note-to-self: This might also mean changing some templates where the numbers are used. Instead, do something like this::

  return render('template', {"Milestone": Milestone, ...})

So you can do this in the templates::

  {% if something.status == Milestone.OPEN %}

instead of 

  {% if something.status == 1 %}


milestone.html, index.html, about-milestone.html, etc.

Comment 2

[Peter Bengtsson [:peterbe]]

Pro tip from Pike::

 find apps/shipping/templates/shipping/ -type f|xargs grep \\.status

Comment 3

[Peter Bengtsson [:peterbe]]

Attachment: No more stray integer

Comment 4

[[github robot]]

Commit pushed to develop at https://github.com/mozilla/elmo

https://github.com/mozilla/elmo/commit/2ab662861f236030cb68e9b2c8b18024fb363023
bug 781851 - milestone status use, r=Pike