Closed
Bug 781869
Opened 12 years ago
Closed 12 years ago
nsHTMLScrollFrame::ReflowScrolledFrame() redundantly passes NS_FRAME_NO_MOVE_VIEW with NS_FRAME_NO_MOVE_FRAME (which already includes the _VIEW bit)
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla17
People
(Reporter: dholbert, Assigned: dholbert)
References
()
Details
Attachments
(1 file)
|
2.26 KB,
patch
|
dbaron
:
review+
|
Details | Diff | Splinter Review |
nsHTMLScrollFrame::ReflowScrolledFrame() has two places where it passes: NS_FRAME_NO_MOVE_FRAME | NS_FRAME_NO_MOVE_VIEW The _VIEW bit there is redundant, because NS_FRAME_NO_MOVE_FRAME is defined to already include it: > 19 #define NS_FRAME_NO_MOVE_FRAME (0x0002 | NS_FRAME_NO_MOVE_VIEW) http://mxr.mozilla.org/mozilla-central/source/layout/generic/nsContainerFrame.h#19 So, I think we can just drop the "| NS_FRAME_NO_MOVE_VIEW" in these instances.
|
Assignee | |
Comment 1•12 years ago
|
||
Comment on attachment 651006 [details] [diff] [review] fix r=dbaron
Attachment #651006 -
Flags: review?(dbaron) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/9556e43af1be
|
||
Comment 4•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/9556e43af1be
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in
before you can comment on or make changes to this bug.
Description
•