782317 - [AccessFu] appinfo.OS == 'Android' does not always mean Android

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Eitan Isaacson [:eeejay]]

Apparently, B2G will also report its OS to be Android, so we should use the build app name instead, 'mobile/android'.

Comment 1

[Eitan Isaacson [:eeejay]]

Attachment: Change platform conditionals for Android Firefox to "mobile/android".

Comment 2

[David Bolter [:davidb] (NeedInfo me for attention)]

Comment on attachment 651439 [details] [diff] [review]
Change platform conditionals for Android Firefox to "mobile/android".

Review of attachment 651439 [details] [diff] [review]:
-----------------------------------------------------------------

r=me. Do you know specifically why b2g chooses to report Android?

Comment 3

[Eitan Isaacson [:eeejay]]

(In reply to David Bolter [:davidb] from comment #2)
> Comment on attachment 651439 [details] [diff] [review]
> Change platform conditionals for Android Firefox to "mobile/android".
> 
> Review of attachment 651439 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> r=me. Do you know specifically why b2g chooses to report Android?

No, I bet it will eventually be "Gonk", but I think the changes here make sense anyway.

Comment 4

[David Bolter [:davidb] (NeedInfo me for attention)]

What about this conditional - is it okay to keep using 'Android' here?

if (Utils.OS != 'Android' && !aEvent.shiftKey)

Comment 5

[Eitan Isaacson [:eeejay]]

(In reply to David Bolter [:davidb] from comment #4)
> What about this conditional - is it okay to keep using 'Android' here?
> 
> if (Utils.OS != 'Android' && !aEvent.shiftKey)

I think so, since that distinguishes device from desktop testing. BTW, I am doing a gesture rework, so that will end up somewhere else soon anyway.

Comment 6

[Eitan Isaacson [:eeejay]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e0876ea69295

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/e0876ea69295