782401 - missing error handling within @supports condition parsing

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P4)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Florian showed me http://test.csswg.org/source/contributors/opera/submitted/css3-conditional/at-supports-030.html , which we fail.

(Some of his other tests that we fail probably aren't valid.)

I audited for missing SkipUntil calls, found one, and it fixed the test.

(At some point we should import Florian's tests to test this.)

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: Add missing SkipUntil call in @supports parsing. ()

Comment 2

[Cameron McCormack (:heycam)]

(In reply to David Baron [:dbaron] from comment #0)
> (At some point we should import Florian's tests to test this.)

I see layout/reftests/w3c-css/received/ looks like the place where importing test from csswg.org would go.  I guess we should wait until the tooling for automatic importing there is set up?

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b300b474c35e
https://hg.mozilla.org/integration/mozilla-inbound/rev/98df684d7a3a (imported tests)

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/b300b474c35e
https://hg.mozilla.org/mozilla-central/rev/98df684d7a3a