782707 - LoadObject(aForceLoad = true) prints bogus assertion if mType == eType_Loading ("Trying to load new plugin with existing content")

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[John Schoenick [:johns]]

If you call LoadObject with aForceLoad while the type is "loading", we assert. We actually just need to return early if we're still in a valid loading state after UpdateObjectParameters()

Comment 1

[John Schoenick [:johns]]

Attachment: Avoid an assertion in nsObjectLoadingContent

If mType == eType_Loading we're waiting on a channel, but if mChannel already exists, we have nothing to do, so take an early return

Comment 2

[John Schoenick [:johns]]

Comment on attachment 651833 [details] [diff] [review]
Avoid an assertion in nsObjectLoadingContent

https://hg.mozilla.org/integration/mozilla-inbound/rev/a5418205a35f

try run:
https://tbpl.mozilla.org/?tree=Try&rev=1e72e421e6b8

Comment 3

[John Schoenick [:johns]]

Attachment: Move waiting-on-channel bailout to after we potentially close it

Arrgh, actually, this check should be lower, so we will close the channel immediately if state changed -- otherwise we'll wait for the channel to finish opening, and only then re-open it.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a5418205a35f

Comment 5

[John Schoenick [:johns]]

Comment on attachment 652173 [details] [diff] [review]
Move waiting-on-channel bailout to after we potentially close it

https://hg.mozilla.org/integration/mozilla-inbound/rev/9d10b718c9a8

try:
https://tbpl.mozilla.org/?tree=Try&rev=46b32a4de584

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/9d10b718c9a8